Repository navigation
Normalize rewritten index.bxm request URLs - #52
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sentry currently reports a rewritten BoxLang request as /index.bxm/foo/bar while reporting the equivalent CFML request as /foo/bar. The shared capture path only recognizes /index.cfm as the rewritten front controller.
Recognize /index.bxm as well, with the existing case-insensitive behavior. Only omit these root front controllers when path_info is nonempty; preserve explicit URLs, other scripts, nested front controllers, bare index requests, and HTTP/HTTPS selection.
Regression coverage exercises both captureMessage and captureException with outbound transport mocked. Before the fix, three of six URL specs failed with the unwanted index.bxm prefix; after it, all six pass. The complete local Lucee 5.4.8.2 harness passes 55/55. Formatting and git diff --check pass. The hosted engine/framework matrix and post-merge snapshot publication will be verified separately.