Repository navigation
Repair browser lockfile and check browser assets in CI - #51
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snapshot publishing failed on Node 22/npm 10 because the browser lockfile incorrectly marked Vitest's nested esbuild dependencies as extraneous. npm ci attempted to install an AIX binary on Linux and exited with EBADPLATFORM.
Reconcile the lockfile with npm 10.9.9 without changing package versions. Add a browser job to the shared test workflow so PRs and snapshots check clean dependency installation, all browser tests, and bundle generation before publishing.
Validation: reproduced the original EBADPLATFORM in Linux amd64 with Node 22.23.3/npm 10.9.9; repaired lockfile passed npm ci, all 28 browser tests, and bundle generation in the same container. No existing package versions changed. git diff --check passed. The module code is unchanged from the development snapshot that passed all 13 engine/framework combinations.