Summarize package statistics, not jobs#49
Merged
Conversation
cottsay
force-pushed
the
cottsay/pkgs-not-jobs
branch
from
8427681 to
2c71875
Compare
To date, the colcon task model has always had a one-to-one relationship between packages and jobs, despite separation in the code. Every job is associated with a single package, but it is possible to associated multiple jobs with any given package. Likely because of this one-to-one relationship, the job identifier and package name have often been used interchangeably throughout the colcon codebase. Because all job identifiers must be unique, we'll need to break this pattern if we are ever to support multiple jobs per package. This change re-orients the statistics presented in the `console_summary` event handler around packages by treating multiple jobs for a single package as if they were a single job, meaning that a package isn't finished building until ALL of the jobs finish. Because all _current_ use cases maintain the one-to-one relationship, this change should not result in any difference in behavior today.
cottsay
force-pushed
the
cottsay/pkgs-not-jobs
branch
from
2c71875 to
9ae3a4d
Compare
Blast545
approved these changes
Mar 1, 2026
Blast545
reviewed
Mar 1, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #49 +/- ##
===========================================
+ Coverage 0.00% 26.10% +26.10%
===========================================
Files 7 7
Lines 286 295 +9
Branches 0 57 +57
===========================================
+ Hits 0 77 +77
+ Misses 286 217 -69
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To date, the colcon task model has always had a one-to-one relationship between packages and jobs, despite separation in the code. All jobs are associated with a single package, but it is possible to associate multiple jobs with any given package.
Likely because of this one-to-one relationship, the job identifier and package name have often been used interchangeably throughout the colcon codebase. Because all job identifiers must be unique, we'll need to break this pattern if we are ever to support multiple jobs per package.
This change re-orients the statistics presented in the
console_summaryevent handler around packages by treating multiple jobs for a single package as if they were a single job, meaning that a package isn't finished building until ALL of the jobs finish.Because all current use cases maintain the one-to-one relationship, this change should not result in any difference in behavior today.