Remove legacy OpenGL fallback definitions#599
Draft
tritao wants to merge 1 commit into
Draft
Conversation
tritao
force-pushed
the
pr/modern-gl/002-legacy-gl-defs
branch
10 times, most recently
from
81a47f2 to
07e361d
Compare
Some build environments still provide very old OpenGL/GLU/WGL headers where many enums are missing unless extension headers are available and included. Add a small fallback header (Inventor/system/gl-fallbacks.h) with known-missing enum values and include it from the central GL header wrapper.
tritao
force-pushed
the
pr/modern-gl/002-legacy-gl-defs
branch
from
07e361d to
3d8101c
Compare
Contributor
Author
|
This PR ended up a bit different than the original version, but before I complete it so it's ready for review, maybe it's worth having an initial discussion. In a branch I've been working on, I end up adding support for the GLAD extension loader, which turns out some of this work obsolete, as it can fully replace the incomplete platform-specific headers and legacy fallbacks in the existing code or in this branch. Do you think replacing the existing legacy OpenGL definitions with GLAD (https://glad.dav1d.de/) is an acceptable path going forward? @VolkerEnderlein |
Contributor
|
There are also these links for reference: |
Member
|
I just had a closer look onto GLAD, it looks well suited for the job. That path looks very promising. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the bundled legacy OpenGL fallback enums/macros and adjust a few call sites accordingly.
Why
include/Inventor/system/gl.hhad accumulated a large set of OpenGL/extension fallback definitions for very old headers. Keeping those in-tree increases maintenance and can hide portability problems by making missing symbols “appear” at compile time.Changes
include/Inventor/system/gl.hdown to a small wrapper that defers toInventor/system/gl-headers.h.Commits
07e361d208: GL: add enum fallbacks for legacy headers