Fix 2 functions calls with HIDDENSTRLEN#20
Open
jamesjer wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Fedora project is in the process of rebuilding all packages with GCC 15, which defaults to the C23 standard. One major change in C23 is that declarations of the form
type f();no longer mean "a function that returnstypewith an unspecified parameter list". Now such a declaration means "a function that returnstypewith an empty parameter list"; i.e., it is the same astype f(void);. This has caused quite a few packages to fail to build, including the Csdp package. While working with the sources to resolve this issue, one thing I did was to replace the BLAS and LAPACK function declarations at the bottom ofinclude/declarations.hwith the appropriate#includedirectives. This turned up two cases where function calls failed to match the declarations. We use a library whereHIDDENSTRLENneeds to be defined (flexiblas). This PR fixes both cases.