Skip to content

feat(hcl): preserve source line/column on parsed attributes and blocks - #11

Merged
yufeiminds merged 5 commits into
mainfrom
copilot/improve-hcl-parser-position-info
Apr 17, 2026
Merged

feat(hcl): preserve source line/column on parsed attributes and blocks#11
yufeiminds merged 5 commits into
mainfrom
copilot/improve-hcl-parser-position-info

Conversation

Copilot AI commented Apr 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Inspect failing CI workflow runs and identify the failing job/step
  • Retrieve failed job logs to pinpoint the exact issue
  • Apply minimal formatting/code fix in affected HCL parser file
  • Run targeted checks/tests for HCL package and formatting verification
  • Re-run final validation and reply to PR comment with commit hash

Copilot AI linked an issue Apr 17, 2026 that may be closed by this pull request
feat: Improve hcl parser to reserve position information (pos: line, col) #10
Closed
Copilot AI and others added 3 commits April 17, 2026 02:47
@yufeiminds
feat(hcl): preserve line/col position on parsed items
66a037e 
Agent-Logs-Url: https://github.com/cogna-dev/x/sessions/4f30beb8-6475-40a6-adfb-b37d3310d5c8

Co-authored-by: yufeiminds <9150374+yufeiminds@users.noreply.github.com>
@yufeiminds
chore(hcl): harden position calculation helper
8b7da4d 
Agent-Logs-Url: https://github.com/cogna-dev/x/sessions/4f30beb8-6475-40a6-adfb-b37d3310d5c8

Co-authored-by: yufeiminds <9150374+yufeiminds@users.noreply.github.com>
@yufeiminds
docs(hcl): clarify position metadata semantics
2b31651 
Agent-Logs-Url: https://github.com/cogna-dev/x/sessions/4f30beb8-6475-40a6-adfb-b37d3310d5c8

Co-authored-by: yufeiminds <9150374+yufeiminds@users.noreply.github.com>
@yufeiminds

yufeiminds commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

@copilot fix ci

Copilot AI changed the title [WIP] Improve HCL parser to reserve position information feat(hcl): preserve source line/column on parsed attributes and blocks Apr 17, 2026
Copilot AI requested a review from yufeiminds April 17, 2026 02:51

Copilot AI commented Apr 17, 2026

Copy link
Copy Markdown
Contributor Author

@copilot fix ci

Fixed. CI was failing in pre-commit format-and-diff due to a formatting mismatch in src/hcl/parse.mbt; I applied the moonfmt-compatible trailing comma update in commit 707f04b.

@yufeiminds
yufeiminds marked this pull request as ready for review April 17, 2026 03:40
@yufeiminds
yufeiminds merged commit 29f43d7 into main Apr 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yufeiminds yufeiminds Awaiting requested review from yufeiminds

Assignees

@yufeiminds yufeiminds

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: Improve hcl parser to reserve position information (pos: line, col)

2 participants

@yufeiminds