Make CSV parsing and polars optional (but default)#1
Open
cgevans wants to merge 2 commits into
Open
Conversation
If someone is using Optimizer directly, then polars is a giant dependency that isn't needed. This makes the file parsing optional (but enabled by default), which in turn makes polars optional.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Author
|
Actually, you also have csv as a dependency, but don't use it at all: an alternative here would be to use csv instead of polars for csv parsing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You've made COFFEE very simple to use, which is great for many users. I, however, insist on making things more difficult for myself, and thus would prefer to use Optimizer directly, which avoids file and parsing overhead. When doing that, polars becomes a large and unnecessary dependency.
So here, I have a minimal change that makes polars optional, but enabled by default. This change lets me use COFFEE without needing to build polars, which makes the build process much faster.
I realize the code here is a bit odd, using multiple gates rather than wrapping things. This avoids indentation, which makes the diff clearer and easier to review; I'd be happy to switch this to a more standard approach if you'd prefer.