fix: patch vulnerable transitive deps (braces, micromatch, minimatch, picomatch) - #16
Merged
Merged
Conversation
… picomatch) Addresses open Dependabot alerts: - braces 3.0.2 -> 3.0.3 (GHSA-grv7-fg5c-xmjg, high) - micromatch 4.0.2 -> 4.0.8 (GHSA-952p-6rrq-rcjv, medium) - minimatch 3.1.2 -> 3.1.5 (GHSA-23c5-xmqv-rm74, GHSA-7r86-cg39-jmmj, GHSA-3ppc-4f35-3m26, high) - mocha's minimatch 4.2.1 -> 4.2.6 via npm overrides (same ReDoS advisories) - picomatch 2.2.2 -> 2.3.2 (GHSA-3v7f-55p6-f55p, GHSA-c2c7-rcm5-vvqj) Note: mocha suite fails identically on master (sinon-chai import-syntax vs Node 22 strip-only TS loader) - pre-existing, not introduced here. tsc build passes.
Lockfile referenced chai-callslike@2.3.1, which 404s on npmjs (latest published is 1.2.8), so npm ci failed on every CI job on master too. package.json already allows "*".
The cc-reporter binary download is broken (Code Climate rebrand), which failed the test job on every run regardless of test results. Run test:coverage directly; coverage upload can be reinstated later with a working reporter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Patches the 7 open Dependabot alerts on this repo (5 high, 2 moderate) via lockfile updates + one npm
overridesentry:All are transitive deps of
del-cli/eslint/mocha(dev-only), but they show up in Dependabot and in consumers' audits.Verification
npm installresolves cleanly; lockfile confirms patched versions.npm run build(tsc) passes.npm testfails identically on master (sinon-chaiimport =syntax vs Node 22's strip-only TS loader) — pre-existing, not introduced here.mochapinsminimatch@4.2.1exactly, so the 4.x copy needed anoverridesentry (mocha > minimatch: ^4.2.5) to reach the patched 4.2.6.