Repository navigation
Fix 25 problems from the log (http, runner, db) - #214
Merged
danielehrhardt merged 5 commits intoOct 19, 2026
Merged
Conversation
…nothing The waiting-for-you section counted as empty only when its whole first line was short. "nothing new from this run. You may want to ..." ran past that and became a task titled "nothing new from this run.". Its first sentence decides now, unless a later one asks or waits.
…t, dismiss the old ones without a site A sentence like "its login failed; it reported that, and it's already on your list" relays another report and files nothing. Open entries that older builds filed as "Unknown service" without an address are dismissed once (migration 98): nothing can be added for them.
Ordering by created_at let SQLite walk every chat and all of its runs to find the few cut off ones, about 130 ms on each cold start.
A first sentence settles a section only when it says nothing else
("None of the quotes fits. Pick A or B" still asks), and pleasantries
or offers after it don't count as asking. A login failure that merely
contains "it reported that" or "already flagged" is still one.
…ng still asks
"No new decisions. Still open: go live Friday or Monday?" asks even
without a "should I". A "nothing" sentence may only name where from
("from this run", "von mir"), so "None from the shortlist works" is
no empty section. "already reported this account" is still a failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two of the problems in this log were real code bugs and are fixed on this branch, along with a slow query on every core start. Everything else was network, sleep, a full disk, or bugs that main already fixes but the installed build doesn't have yet. Typecheck passes and the related core test files pass (189 tests). The full core suite has 1 failure out of 2045 tests, and it isn't from this change: the Cua Driver "a
--versionthat hangs" test inupdates.test.ts. Its fake script gets killed by the test's 300 ms timeout before it writes its log line, which looks like timing under load; I didn't change that code. Main hasn't moved since the branch was made, so it merges cleanly.Changes
runner/openDecision.ts): "Waiting for you: nothing new from this run." followed by more text in the same paragraph became a task called "nothing new from this run." The check only treated a section as empty when its whole first line was short. Now it is also empty when the first sentence says only "nothing" ("nothing new from this run.", "None for now.", "Nichts Neues von mir.") and no later sentence in the section asks something. Real asks still create a task, for example "None of the quotes fits. Pick A or B", or "No new decisions. Go live Friday or Monday?". Run against the actual answers stored on this Mac, the old code had made three such false tasks, and the new code skips all three. The real decisions in the same set still come through.runner/stream.ts): sentences like "its login failed … it's already on your list" or "which I already flagged for you" now create no entry. Real failures still do, such as "it reported that the password is invalid" or "the site already reported this account as locked".services/resume.ts): the startup query took 114–136 ms because it walked every chat and read all of its runs. It now orders by+r.created_at, so SQLite reads only the recently finished runs fromidx_runs_finished. Results and order are the same, and the every-minute "offline" query gets the same change.A review pass found three regressions in my first versions of these patterns (real decisions and real login failures being dropped). All are fixed and covered by tests.
Not code bugs, left as they are
GET /api/calls/:id/audioerror: the ElevenLabs request timed out during a network outage. Main already logs this at info level (Implement attachments to the expo app #59); it isn't installed yet.sleep 99999. Stopping them is correct.persist in-flight message failed: the disk was full.For Daniel
Task #60 · done by Self-Healer with Godmode Bot