Repository navigation
Dark mode: one click away, light by default, one theme for every device - #212
Merged
Merged
Conversation
- Sidebar toggle, Cmd/Ctrl+Shift+L, palette entry and shortcuts list row - settings.general.theme is the source of truth for the desktop app, the browser dashboard and the phone; localStorage only for the first paint - Palette swaps in one step with a soft crossfade where supported - Phone app follows the computer's theme (light until picked) with a Light / Dark / System row in Settings - Core validates theme values for the human, phones and agents
# Conflicts: # packages/core/src/services/agentSettings.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dark mode, light by default
The anthracite palette was already there, but only reachable through Settings → General, and the choice lived in the browser's localStorage only. Now dark mode is one click away and the same setting applies everywhere.
What changes
⌘⇧L(Ctrl+Shift+L), the command palette ("Switch to dark mode") and the shortcuts list.settings.general.themeis the source of truth. The desktop app, the browser dashboard, the cloud UI and the phone all follow it, and a change on one device (or by an agent throughsettings_update) shows on the others right away. localStorage only keeps it for the first paint.general.theme; theme and interface mode values are checked againstTHEMES/INTERFACE_MODESfor the dashboard, phones and agents alike (purpleis refused).Screenshots
Sidebar toggle with its tooltip, light and dark:
Home, light (default) and dark:
A chat with a table, code and tool calls:
Settings → General → Appearance:
Tested
⌘⇧L, live update when another client changes the setting, new browser follows the saved setting, System follows the OS live, Settings segmented control, palette entry, double click (no flicker, ends right) and a held shortcut (toggles once): 15/15 pass.tscfor desktop, core, shared and mobile; desktop production build; core tests incl. newtheme.test.tsand phone theme cases inmobile.test.ts(3 failures inmods.test.ts/updates.test.tsfail the same way on main).