Repository navigation
Fix 19 problems from the log (runner, perf, db) - #207
Merged
danielehrhardt merged 3 commits intoOct 19, 2026
Merged
Conversation
The fallback that reads the final answer for a failed login now only files an entry when the run used the browser and a real page is open. Without one it named no service and only quoted an error or another agent's report.
…blems-from-the-log-runner-perf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing-login entries from an answer's text
The real bug was the fallback that reads an agent's final answer for a failed login (
detectMissingLogininpackages/core/src/runner/runner.ts). When the run had no browser page open, it still filed an entry, named "Unknown service" and with no URL. Most of the time the matched sentence was just a quote: Claude's own "Failed to authenticate." error, or an agent reporting on another agent's missing login. That fed itself: each report on such an entry created the next one.Fix: the fallback now files an entry only when all three are true:
usedBrowserinrunner/stream.ts:mcp__browser__*, which covers both the host and the VM's browser-use; Godmode's ownbrowser_profile*tools and other servers'browser_*tools don't count);An explicit
report_missing_logincall works as before.Tests:
usedBrowsertest intest/stream.test.ts.test/runner.test.ts: the old test expected an "Unknown service" entry. It now checks that a login-failure answer from a run without a browser page files nothing.pnpm -r typecheckis clean.stream,runner,missing-loginsandmissing-login-totptests: 77 pass, 0 fail.Latest
origin/main(v0.2.19 version bump) is merged in, with no conflicts.Not code bugs (nothing changed)
pmset disablesleepfailure: by design, from before the one-time admin prompt was answered.What you need to do
Task #57 · done by Self-Healer with Godmode Bot