Skip to content

fix: add json parse error handler #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
7eliassen merged 4 commits into from
May 12, 2026
Merged

fix: add json parse error handler #300

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f322e19
fix: add json parse error handler
7eliassen Mar 29, 2026
dcce6d2
chore: add FastifyError handling
7eliassen Apr 7, 2026
b29d04b
chore: add tests
7eliassen Apr 7, 2026
c86eb6e
refactor: rename error handler
7eliassen May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/presentation/http/http-api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import UploadRouter from './router/upload.js';
import { ajvFilePlugin } from '@fastify/multipart';
import { UploadSchema } from './schema/Upload.js';
import { NoteHierarchySchema } from './schema/NoteHierarchy.js';
import { StatusCodes } from 'http-status-codes';

const appServerLogger = getLogger('appServer');

Expand Down Expand Up @@ -372,6 +373,21 @@ export default class HttpApi implements Api {

return;
}
/**
* JSON parse errors (invalid request body)
*/
if (error instanceof SyntaxError && error.message.includes('JSON')) {
Comment thread
7eliassen marked this conversation as resolved.
Outdated
this.log.warn({ reqId: request.id }, 'Invalid JSON in request body');

return reply
.code(StatusCodes.BAD_REQUEST)
.type('application/json')
.send({
message: 'Invalid JSON in request body',
error: 'Bad Request',
statusCode: StatusCodes.BAD_REQUEST,
Comment thread
7eliassen marked this conversation as resolved.
Outdated
});
Comment thread
7eliassen marked this conversation as resolved.
}
/**
* If error is not a domain error, we route it to the default error handler
*/
Expand Down
Loading