Repository navigation
Add a write_changes flag - #112
Open
TheGiraffe3 wants to merge 8 commits into
Open
TheGiraffe3 wants to merge 8 commits into
TheGiraffe3 wants to merge 8 commits into
Conversation
Member
|
Seems reasonable to me, but a test and README update would be good |
Author
|
Added a test. README update was already done |
Member
|
Okay, thinking more about this and how actions like this (pre-commit, prek, etc.) normally operate, the action typically fails if it makes changes. I think we should probably do the same. So maybe in write mode we should do:
And longer-term, we update |
Author
|
If we're deleting output of the second run, it doesn't print the fixed lines. Should we be sending that to stdout too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the equivalent of specifying
-wwith the original codespell.Feedback welcome.
related: #68