ポッドキャスト各エピソードにサムネイルの代わりに YouTube 埋め込みプレイヤーを表示#1821
Merged
Conversation
- `_youtube_embed.html.erb` パーシャルを追加（16:9 レスポンシブ、プレイリスト付き、rel=0） - `convert_shownote` でサムネイル画像を YouTube embed に置換 - `Podcast::YOUTUBE_PLAYLIST_ID` 定数を追加 - `.episode-cover` の max-width 制約を削除してフル幅表示に対応 - テストフィクスチャに YouTube URL を追加
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<img>）を YouTube 埋め込みプレイヤーに置換（convert_shownoteで処理）_youtube_embed.html.erbパーシャルで HTML を管理（16:9 レスポンシブ、プレイリスト付き、rel=0）Podcast::YOUTUBE_PLAYLIST_ID定数を追加.episode-coverのmax-width: 70%制約を削除してフル幅表示に対応Test plan
bundle exec rspec spec/— 217 examples, 0 failures/podcasts/35で YouTube embed がフル幅で表示されることを確認rel=0）