ポッドキャスト全エピソードから不要な rel='noopenner' 属性を削除#1820
Merged
Merged
Conversation
rel='noopener' が正しい表記。35ファイルを一括修正。
Member
Author
|
PR #1818 のレビューで指摘された 参照: #1818 (comment) |
現代のブラウザは target='_blank' に自動的に noopener を適用するため、 タイポのある rel 属性を削除してシンプルにする。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
全35エピソードで
rel='noopenner'と誤表記されていた属性を削除。理由
現代のブラウザ(Chrome 88+, Firefox 79+, Safari 12.1+)は
target='_blank'に自動的にnoopenerを適用するため、この属性は不要。タイポのまま残すより、シンプルに削除する方が明快。変更内容
public/podcasts/0.md〜34.md(35ファイル)のrel='noopenner'を削除参照
PR #1818 のレビューで指摘: #1818 (comment)