chore(zed): make coder_script conditional on settings input#934
Open
matifali wants to merge 2 commits into
Open
chore(zed): make coder_script conditional on settings input#934matifali wants to merge 2 commits into
matifali wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
coder_scriptresource for configuring Zed settings was always created, even when no settings were provided. The script handled this at runtime with an early exit check, but it's cleaner to not create the resource at all.Changes
count = var.settings != "" ? 1 : 0tocoder_script "zed_settings"so it's only created when settings are providedSETTINGS_B64runtime check from the shell scriptzed.tftest.hclto use indexed reference (coder_script.zed_settings[0]) and assert no resource is created when settings is emptymain.test.tsto verify nocoder_scriptexists in state when settings is emptyThis follows the same pattern used in cursor, windsurf, kiro, and antigravity modules.