feat!: drop multi-window support and name sessions after the cwd#8
Merged
Conversation
Sessions now own exactly one command. The windows CLI command, the windows wire command, and all window-management key bindings (C-a c, n, p, 0-9, C-a C-a, k, w) are gone; C-a d/C-d detach, C-a l/C-l redraw, and C-a a literal C-a remain. The info reply carries an output-idle field so wait --idle works without window listings, and ls/peek lose their window columns and JSON keys. boo new without a name now uses the basename of the working directory (sanitized to the session-name character set), falling back to the process id when that name is taken or unusable. Bump version to 0.2.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes multi-window semantics entirely: a session owns exactly one command. Also makes
boo newdefault the session name to the current directory's basename.Breaking changes
boo windows(CLI and wire command) is removed.C-a c,n,p,0-9,C-a C-a,k,wand theirC-xvariants) are removed. Remaining:C-a d/C-ddetach,C-a l/C-lredraw,C-a aliteralC-a.lsloses theWINDOWScolumn and"windows"JSON key.peek --jsonloses the"window"key.WINDOWis no longer set in the child environment.command exited.New behavior
boo newwithout a name uses the cwd basename, sanitized to the session-name charset (invalid bytes become-, truncated to 64), falling back to the pid when taken or unusable.infowire reply carries an output-idle field sowait --idlekeeps working without window listings.Version bumped to 0.2.0 (release tagged after merge).
Decision log
?*Windowon the daemon; window ids, the active index, and switch logic are deleted rather than special-cased.wait --idlepreviously read per-window idle fromwindows; the daemon now reports output idle (out_idle_ms) ininfo, keepingidle_msas the session activity clock used byls.sanitizeNamehelper inpaths.zigwith unit tests; taken-ness is checked by socket-file existence, with pid fallback preserving the old behavior.runIn(cwd, argv);exe_pathis resolved to an absolute path because it is build-root relative and broke spawning with a custom cwd.Testing
zig build test-all(Debug and ReleaseSafe): 67/67 pass, including a new end-to-end test for cwd-derived names and pid fallback.ls/ls --json,wait --for/--idle,peek --json,windowsnow exits 2,exorcise.Generated with Coder Agents on behalf of @kylecarbs.