fix: print PATH setup instructions when install dir is not in PATH#41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS,
/usr/local/binis not user-writable (Homebrew lives in/opt/homebrewon Apple Silicon), so the installer falls back to~/.local/bin, which is not in the default macOS PATH. The script only printed a bare warning that was easy to miss incurl | shoutput and offered no remediation.The install location logic is unchanged. When the install directory is not in PATH, the script now:
~/.zshrc,~/.bashrc, orfish_add_path), using$HOME-relative paths where possible.sudo BOO_INSTALL_DIR=/usr/local/binfor a system-wide install.Example output for a zsh user:
Testing and decisions
shellcheck(clean).SHELLset to zsh, bash, fish, and dash; each prints the correct instructions, and no warning is printed when the install dir is already in PATH.sudoescalation: prompting for sudo insidecurl | shhangs unattended installs, and modern installers (rustup, uv, bun) install user-local without sudo.Generated by Coder Agents on behalf of @kylecarbs.