Skip to content

fix(test): close echo race in the kitty detach integration test #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kylecarbs merged 1 commit into from
Jun 10, 2026
+7 −2
Merged

fix(test): close echo race in the kitty detach integration test #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions test/integration.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -947,8 +947,13 @@ test "kitty keyboard apps: encoded C-a still detaches" {
// The app enters the alt screen and enables kitty keyboard
// disambiguation, like a modern TUI. The passthrough mirrors both
// onto the client's terminal, which then encodes Ctrl+A as
// CSI 97;5u instead of 0x01.
try client.send("printf '\\033[?1049h\\033[H\\033[2JKITTY-APP\\n\\033[>1u'; read x\r");
// CSI 97;5u instead of 0x01. The marker is printed after the
// kitty enable and assembled from two printf arguments: by the
// time it is visible the daemon has processed the enable, and the
// echoed command line never contains the assembled marker (the
// tty echo would otherwise satisfy the wait while the keys still
// leak into the window).
try client.send("printf '\\033[?1049h\\033[H\\033[2J\\033[>1uKITTY-%s\\n' APP; read x\r");
try client.waitFor("KITTY-APP");

// Press C-a d the way a kitty-mode terminal sends it.
Expand Down
Loading