No CodeCov comment in pull request.#653
Merged
knod merged 1 commit intoJul 11, 2018
Merged
Conversation
MichaelDimmitt
changed the title
MichaelDimmitt
force-pushed
the
no-codecov-comment-in-pull-requests
branch
from
5a3ec3d to
14547b7
Compare
MichaelDimmitt
changed the title
Collaborator
Author
|
disregard that it looks like I deleted the codecov comment this was because I made an accidental push earlier and have since corrected the errant code push. |
Collaborator
|
Thanks, @MichaelDimmitt ! For now we'll remove them completely. Later we'll talk about features we want to bring back in. Would appreciate your thoughts if you've got some. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are the docs related to this pull request.
https://docs.codecov.io/v4.3.6/docs/pull-request-comments
Current commit removes any comments CodeCov would implement.
However, the CodeCov yml can be customized further to comment individually regarding:
"reach, diff, flags, files"
CodeCov can also "only post the comment if coverage changes"
@knod
If those additions are not needed this pr should be fine for removing the diff from every pr.
for example if you only wanted the graph you would put, "reach"
in the config.yml file as noted in the doc
This is what it looks like if you include the graph:
md-web-client#2
But not the other information in the CodeCov comment for pull requests.