Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds VoxCPM (OpenBMB, Apache-2.0) as a TTS provider, pointed at a self-hosted OpenAI-compatible endpoint.
VoxCPM served through vLLM-Omni speaks
/v1/audio/speech, the same shape the existingopenai-compatibleprovider already talks. It gets its own engine id for three reasons:fetchOpenAITTSAudiothrows on an empty API key, but a self-hosted server has no auth.Authorizationis now sent only when a key is configured.http://localhost:8000/v1,openbmb/VoxCPM2,wav.Playback reuses
BufferedAudioTTSPlayer(now exported) since VoxCPM returns a whole file per chunk. Mobile goes through the existingTrackPlayerCloudTTSPlayer.Bug fixes
Three pre-existing bugs, each of which blocks the provider outright, so they are here rather than in a separate PR. Each is its own commit.
AudioContextwas never resumed inBufferedAudioTTSPlayer, so playback was silent with no UI feedback at all.normalizeTTSConfigis what fills in the built-in profiles, and the persist layer only calls it when a config file already exists, so with notts.jsonon disk the settings profile list was empty for every provider.stop()never cancelled the in-flight request because the abort signal was never passed tofetchAudio.DashScopeTTSPlayerandPCMStreamingTTSPlayerhave the sameAudioContextgap and are deliberately left alone: verifying either needs provider credentials I do not have. Happy to open a separate issue.Testing
pnpm test: 619 pass (598 onmain), 21 newpnpm lint: no new findingstsc --noEmitoncore,appandapp-expo: matches themainbaselineVoice Design verified on VoxCPM2 (RTX 4090, bfloat16, RTF 0.32, 48kHz). Same sentence, four voice descriptions: ASR transcripts contain the sentence and none of the description wording, so the prefix is consumed as a control signal rather than spoken. Median F0 follows the description, 267.8 Hz for "young woman" against 110.7 Hz for "older man", with non-overlapping P10–P90 ranges.