Skip to content

Keep treasury vote counts in sync when votes are cast #655

Closed

Description

@codebestia

Branch: Open your PR against dev. PRs targeting main are closed automatically.

Description:
treasuryProposals has approvalsCount and rejectionsCount columns, but handleVote in routes/treasury.ts only inserts into proposalVotes and never updates them, so they stay at 0.

Acceptance criteria:

  • The vote insert and the counter increment run in one transaction
  • GET /treasury/proposals returns correct counts
  • Test: two approvals and one rejection give approvalsCount = 2 and rejectionsCount = 1

Activity

  1. msbanky commented on Oct 22, 2026

    @msbanky

    @msbanky has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    i can work on this kindly assign please

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @msbanky to this issue.

  2. Kehinde80 commented on Oct 22, 2026

    @Kehinde80

    @Kehinde80 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi Maintainer, I’ve gone through the issue thoroughly and have a good understanding of what needs to be done. I’m confident I can implement a solution that meets the expectations. I’d appreciate it if you could assign this task to me.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Kehinde80 to this issue.

  3. bandanadivya commented on Oct 22, 2026

    @bandanadivya

    @bandanadivya has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi Maintainer, I’ve reviewed this issue and understand what needs to be done. I’m confident I can handle it. Please assign it to me. Thank you!

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @bandanadivya to this issue.

  4. Temibell commented on Oct 22, 2026

    @Temibell

    @Temibell has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi Maintainer, I can fix this pls assign. ETA 5hrs

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Temibell to this issue.

  5. drips-wave commented on Oct 22, 2026

    @drips-wave

    Congratulations, @bandanadivya! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @bandanadivya: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  6. github-actions commented on Oct 22, 2026

    @github-actions

    Closed by #686, merged into dev.

  7. drips-wave commented on Oct 22, 2026

    @drips-wave

    This issue has been completed by @bandanadivya as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @bandanadivya: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions