build(deps): Bump jscpd from 4.2.4 to 5.0.9#63
Conversation
Bumps [jscpd](https://github.com/kucherenko/jscpd/tree/HEAD/rust/jscpd) from 4.2.4 to 5.0.9. - [Release notes](https://github.com/kucherenko/jscpd/releases) - [Changelog](https://github.com/kucherenko/jscpd/blob/master/CHANGELOG.md) - [Commits](https://github.com/kucherenko/jscpd/commits/v5.0.9/rust/jscpd) --- updated-dependencies: - dependency-name: jscpd dependency-version: 5.0.9 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the jscpd dependency to version 5.0.9, transitioning to the new Rust-based engine. While Codacy indicates the project remains up to standards, the major version bump introduces potential risks regarding CLI compatibility and output formatting in CI/CD pipelines.
Two primary improvements are identified: moving the dependency to devDependencies to prevent bloating production builds and pinning the version to ensure deterministic, secure builds.
About this PR
- The upgrade from version 4 to 5 involves a rewrite in Rust. While backward compatibility is expected for many configuration fields, monitor for breaking changes in CLI behavior or output formatting that could impact CI pipelines or scripts parsing the results.
Test suggestions
- Verify that existing
jscpdconfiguration files (e.g.,.jscpd.json) and CI scripts remain compatible with the new Rust-based v5 engine.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that existing `jscpd` configuration files (e.g., `.jscpd.json`) and CI scripts remain compatible with the new Rust-based v5 engine.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| "homepage": "https://github.com/codacy/codacy-duplication-jscpd#readme", | ||
| "dependencies": { | ||
| "jscpd": "^4.2.4" | ||
| "jscpd": "^5.0.9" |
There was a problem hiding this comment.
🔴 HIGH RISK
Two issues found for the jscpd dependency:
- It is a development-time tool used for duplication detection and should be moved from
dependenciestodevDependenciesto avoid unnecessary production overhead. - It currently uses a version range (
^5.0.9). To prevent dependency hijacking and ensure deterministic builds, it is recommended to pin the dependency to an exact version.
| "jscpd": "^5.0.9" | |
| "jscpd": "5.0.9" |
(Note: Move this entry to the devDependencies section).
|
Superseded by #64. |
Bumps jscpd from 4.2.4 to 5.0.9.
Release notes
Sourced from jscpd's releases.
... (truncated)
Changelog
Sourced from jscpd's changelog.
... (truncated)
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)