build(deps): bump nokogiri from 1.15.3 to 1.19.3 in /docs/multiple-tests/multi-patterns/src#216
Conversation
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.15.3 to 1.19.3. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.15.3...v1.19.3) --- updated-dependencies: - dependency-name: nokogiri dependency-version: 1.19.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
While this PR successfully bumps nokogiri to version 1.19.3 to address several security vulnerabilities, it introduces two critical regressions that must be addressed before merging.
First, a major security regression occurred during dependency resolution: the rack gem was downgraded from version 2.2.6.4 to 1.6.13. This older version is nearly a decade old and contains numerous high-severity vulnerabilities (DoS, XSS, and session management flaws). Second, the PR replaces the generic 'ruby' platform with 'x86_64-linux', which will break the local development environment for any team members using different architectures, such as macOS (Darwin).
About this PR
- The PLATFORMS section change from 'ruby' to 'x86_64-linux' suggests a configuration change in the build environment that may break dependency resolution for developers on non-Linux systems. This should be reverted to include the generic 'ruby' platform.
Test suggestions
- Verify that nokogiri is updated to 1.19.3 in Gemfile.lock
- Ensure that the rack gem version remains stable or is upgraded
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Ensure that the rack gem version remains stable or is upgraded
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| racc (~> 1.4) | ||
| racc (1.7.1) | ||
| rack (2.2.6.4) | ||
| rack (1.6.13) |
There was a problem hiding this comment.
🔴 HIGH RISK
Significant security regression detected: rack was downgraded from 2.2.6.4 to 1.6.13. This version is over 8 years old and introduces at least 15 known vulnerabilities, including high-severity risks like memory exhaustion DoS (CVE-2023-27530) and XSS (CVE-2026-25500). This major downgrade likely occurred as a side effect of the dependency resolution for the nokogiri update.
Recommended Action: Investigate your Gemfile constraints to ensure rack is pinned to ~> 2.2 or higher, then run bundle update rack to restore a secure version.
See Issue in Codacy
See Issue in Codacy
See Issue in Codacy
See Issue in Codacy
See Issue in Codacy
See Issue in Codacy
|
|
||
| PLATFORMS | ||
| ruby | ||
| x86_64-linux |
There was a problem hiding this comment.
🟡 MEDIUM RISK
Suggestion: Replacing the generic ruby platform with x86_64-linux breaks cross-platform compatibility for developers on other architectures (e.g., Apple Silicon Macs). If specific Linux support is required for CI/CD, you should add it as an additional platform rather than replacing the default entry.
Suggested Fix: Run bundle lock --add-platform x86_64-linux to support both generic ruby environments and specific Linux builds.
|
Superseded by #220. |
Bumps nokogiri from 1.15.3 to 1.19.3.
Release notes
Sourced from nokogiri's releases.
... (truncated)
Changelog
Sourced from nokogiri's changelog.
... (truncated)
Commits
c139a3dversion bump to v1.19.37501a63fix: backtracking in CSS tokenizer rules (v1.19.x backport) (#3627)03e7968test: skip CSS tokenizer benchmarks on JRubyb984b7efix: ReDoS in CSS tokenizer ident rule0092623fix: ReDoS in CSS tokenizer STRING ruleee17d33fix: memory leak in XSLT transform (backport to v1.19.x) (#3624)ce188a3doc: update CHANGELOGcaeaac4fix: memory leak in XSLT transform25220bfdep(test): test against libxml-ruby v6 (#3618)0caeb21doc: add security warnings for untrusted XSLT stylesheetsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.