Skip to content

Update for recent Rust version#5

Open
anselanza wants to merge 4 commits into
cnwzhjs:masterfrom
RandomStudio:update-min
Open

Update for recent Rust version#5
anselanza wants to merge 4 commits into
cnwzhjs:masterfrom
RandomStudio:update-min

Conversation

@anselanza

Copy link
Copy Markdown

This Pull Request attempts to leave the basic crate structure the same (rpos_drv is still a separate crate) while making some adjustments to get up to date with later Rust compiler versions.

@Katletos

Copy link
Copy Markdown

Thank you man!

@anselanza

Copy link
Copy Markdown
Author

Great, so... can this be merged?

@anselanza

Copy link
Copy Markdown
Author

Sorry to bug you, @cnwzhjs but would you mind having a look in case this can be merged? (And published on crates.io)?

@anselanza

Copy link
Copy Markdown
Author

Or @Katletos

@Katletos

Copy link
Copy Markdown

Or @Katletos

I am not a maintainer of this repository

@Katletos

Copy link
Copy Markdown

Or @Katletos

But thanks again for your changes, they have helped me a lot

@anselanza anselanza changed the title Update min Update for recent Rust version Nov 12, 2024
@anselanza

Copy link
Copy Markdown
Author

@cnwzhjs I would love to have this repository available for installation via crates.io (also so that I can publish other projects which depend on it).

Any chance of bringing this project up to date with this Pull Request and publishing it on crates.io?

Or, would you like to give ownership over the project to someone else? Or let someone else publish this on crates.io ?

@anselanza

Copy link
Copy Markdown
Author

Oh, I see it is published on https://crates.io/crates/rplidar_drv

Then I guess I would like to know whether it can be updated so I can install the newer version from other projects?

@mik90

mik90 commented Dec 21, 2024

Copy link
Copy Markdown

@anselanza it might be best to publish your forked version on crates.io. Not sure what'd be best naming-wise (rplidar_drv2 is always an option 😆 ), but I'd like to pull it into other projects as well.

@anselanza

Copy link
Copy Markdown
Author

@anselanza it might be best to publish your forked version on crates.io. Not sure what'd be best naming-wise (rplidar_drv2 is always an option 😆 ), but I'd like to pull it into other projects as well.

OK, done.

It's a little messy now (I had to include the rpos_drv as a module rather than a crate, because the one published on crates.io was ALSO out of date, but it "works".

Visit https://crates.io/crates/rplidar_drv_rs
Install with cargo add rplidar_drv_rs (the _rs is the only added part of the crate name)

@anselanza anselanza closed this Dec 23, 2024
@mik90

mik90 commented Dec 23, 2024

Copy link
Copy Markdown

@anselanza maybe the PR should be left open in case the repo owner comes back. It'd also offer some better discoverability for people trying to find an updated version.

Thank you for publishing it! Have a happy holidays 🥳

@anselanza anselanza reopened this Dec 23, 2024
@anselanza

Copy link
Copy Markdown
Author

Good idea, reopened for now.

@anselanza anselanza mentioned this pull request Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants