Skip to content

[17.0] Extend convertToRaw to support streamer files#51322

Open
fwyzard wants to merge 1 commit into
cms-sw:CMSSW_17_0_Xfrom
fwyzard:convertToRaw_streamer_170x
Open

[17.0] Extend convertToRaw to support streamer files#51322
fwyzard wants to merge 1 commit into
cms-sw:CMSSW_17_0_Xfrom
fwyzard:convertToRaw_streamer_170x

Conversation

@fwyzard

@fwyzard fwyzard commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

PR description:

Extend the convertToRaw to support reading streamer files (.dat), as well as edm files (.root).

PR validation:

Tested converting streamer files from run 404926 to .raw format, and running the heavy ions HLT menu on the result.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backported of #51321 to 17.0.x for Run 3 developments.

@fwyzard

fwyzard commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

backport #51321

@fwyzard

fwyzard commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

type ngt

@cmsbuild

cmsbuild commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@fwyzard

fwyzard commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild

Copy link
Copy Markdown
Contributor

@cmsbuild

cmsbuild commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @fwyzard for CMSSW_17_0_X.

It involves the following packages:

  • HLTrigger/Tools (hlt)

@Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-556efa/54278/summary.html
COMMIT: f894c93
CMSSW: CMSSW_17_0_X_2026-06-25-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51322/54278/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 4337615
  • DQMHistoTests: Total failures: 39
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4337556
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
  • Checked 232 log files, 203 edm output root files, 54 DQM output files
  • TriggerResults: no differences found

@mmusich

mmusich commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

+hlt

@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_17_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_20_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild

Copy link
Copy Markdown
Contributor

@cmsbuild

Copy link
Copy Markdown
Contributor

Pull request #51322 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

Extend convertToRaw to support streamer (.dat) files.
Update the documentation and unit tests accordingly.
@cmsbuild

Copy link
Copy Markdown
Contributor

@cmsbuild

Copy link
Copy Markdown
Contributor

Pull request #51322 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

@fwyzard

fwyzard commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-556efa/54296/summary.html
COMMIT: ef32b3c
CMSSW: CMSSW_17_0_X_2026-06-25-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51322/54296/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 4337615
  • DQMHistoTests: Total failures: 58
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4337537
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
  • Checked 232 log files, 203 edm output root files, 54 DQM output files
  • TriggerResults: no differences found

@mmusich

mmusich commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

+hlt

@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_17_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_20_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants