[cmsShow] Fix crash on load of configuration in release CMSSW_20_X#51282
Open
alja wants to merge 1 commit into
Open
[cmsShow] Fix crash on load of configuration in release CMSSW_20_X#51282alja wants to merge 1 commit into
alja wants to merge 1 commit into
Conversation
Contributor
|
@alja, CMSSW_20_1_X branch is closed for direct updates. cms-bot is going to move this PR to master branch. |
Contributor
|
cms-bot internal usage |
Contributor
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51282/49892 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description:
cmsShow crashes when a pre-existing Fireworks configuration is present:
The Fireworks configuration parser attempts to load collections with the reco namespace, and the program crashes when accessing dictionaries within FWItemAccessorFactory.
A workaround for the problem is that CMSSW_20_1_X releases and beyond add the io_v1 namespace in the configuration type at runtime if the io_v1 string is not already added.
PR validation:
To test, run cmsShow with configuration from the Fireworks/Core/macros directory and with a data file from the CMSSW_20_X release validation.