Skip to content

PR Profiling: Add link for diff of IB and PR Vtune reports and add script to generate page with the diff of IB and PR sorted-CPU-RES reports#2787

Open
gartung wants to merge 24 commits into
cms-sw:masterfrom
gartung:gartung-vtune-diff-link
Open

PR Profiling: Add link for diff of IB and PR Vtune reports and add script to generate page with the diff of IB and PR sorted-CPU-RES reports#2787
gartung wants to merge 24 commits into
cms-sw:masterfrom
gartung:gartung-vtune-diff-link

Conversation

@gartung

@gartung gartung commented Jun 10, 2026

Copy link
Copy Markdown
Member

No description provided.

@cmsbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @gartung for branch master.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild

cmsbuild commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@gartung gartung linked an issue Jun 10, 2026 that may be closed by this pull request
@gartung

gartung commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

enable profiling

@cmsbuild

Copy link
Copy Markdown
Contributor

Pull request #2787 was updated.

1 similar comment
@cmsbuild

Copy link
Copy Markdown
Contributor

Pull request #2787 was updated.

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d44c3/53842/summary.html
COMMIT: 7628af1
CMSSW: CMSSW_20_1_X_2026-06-10-1100/el9_amd64_gcc13
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2787/53842/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3248390
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248372
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 159 edm output root files, 44 DQM output files

@makortel

Copy link
Copy Markdown
Contributor

I see links to the IB and PR VTune reports but not the diff
image

How about moving the VTune link between the FastTimerService and ModuleAllocMonitor? Then the time-based tools would be next to each other.

@gartung

gartung commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

Need to wait for the next IB to generate the vtune top-down json file before adding the comparison scripting.

@cmsbuild

Copy link
Copy Markdown
Contributor

Pull request #2787 was updated.

2 similar comments
@cmsbuild

Copy link
Copy Markdown
Contributor

Pull request #2787 was updated.

@cmsbuild

Copy link
Copy Markdown
Contributor

Pull request #2787 was updated.

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d44c3/53846/summary.html
COMMIT: 76731da
CMSSW: CMSSW_20_1_X_2026-06-10-1100/el9_amd64_gcc13
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2787/53846/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3248390
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248372
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 159 edm output root files, 44 DQM output files

gartung added 22 commits June 16, 2026 09:51
@cmsbuild

Copy link
Copy Markdown
Contributor

Pull request #2787 was updated.

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d44c3/53985/summary.html
COMMIT: 618fc43
CMSSW: CMSSW_20_1_X_2026-06-15-2300/el9_amd64_gcc13
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2787/53985/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3414477
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3414456
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 195 log files, 163 edm output root files, 45 DQM output files

@gartung

gartung commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

@makortel I generalized the script that generates the doEvent summary to include all produce functions. I had copilot look at all produce functions and find the parent function. It found that "EventSetup Producers" were not included in the parent function list. This should lead to no missing produce functions in the diff report unless a new producer was added/removed in the PR.

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d44c3/53992/summary.html
COMMIT: 618fc43
CMSSW: CMSSW_20_1_X_2026-06-15-2300/el9_amd64_gcc13
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2787/53992/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3414477
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3414456
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 195 log files, 163 edm output root files, 45 DQM output files

@gartung

gartung commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

please test

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d44c3/53998/summary.html
COMMIT: 618fc43
CMSSW: CMSSW_20_1_X_2026-06-16-1100/el9_amd64_gcc13
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2787/53998/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3414477
  • DQMHistoTests: Total failures: 28
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3414431
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 195 log files, 163 edm output root files, 45 DQM output files

@makortel

Copy link
Copy Markdown
Contributor

I think the EventSetup producers should not be added in "RECO event loop". The EventSetup producers are not run on every event, but on IOV boundaries (which is likely once per job in all test jobs).

@gartung

gartung commented Jun 17, 2026

Copy link
Copy Markdown
Member Author

OK. Adding them did not make the number of IB vs PR functions reported the same. I will remove them from the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add diff table to VTune report

4 participants