Repository navigation
Rename period to era - #27
Merged
Merged
Conversation
Author
|
tested with cms-flaf/FLAF#347 |
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The StatInference part of the multi-era change set. With cms-flaf/FLAF#347, FLAF tasks take
--era(a one-era tuple for now) and refuseperiodin every form, so the tasks here move to the new parameter:era=(e,);get_sub_periodsbecomesget_sub_eras;Setup(…, self.era[0], …);--era.The meta-era logic (
meta_era, the card eras) is unchanged. Converting the card stages to several eras per task is a later step.Changes
law/StatInferenceTask.py,CreateDatacardsTask.py,PreprocessShapesTask.py,ResonantLimitsTask.py,ResonantLimitsAndHistPlotTask.py,MergedHists.py: the rename..github/copilot-instructions.md: the era facts.The rename-check job (the other A PRs had it too) is not part of this PR. Its script reaches FLAF
mainonly with cms-flaf/FLAF#347, and a follow-up PR adds the job then. Run locally at e1392d7:python3 FLAF/run_tools/check_era_rename.py --repo StatInferencegives rc 0.Merge after cms-flaf/FLAF#347 and before the analyses, which then point their StatInference gitlinks at the merged SHA. StatInference has no docs site; the change is described in
.github/copilot-instructions.md.Testing
ResonantLimitsAndHistPlotTask, CI card config over Run3_2022–2023BPix) with every companion. The task turns HistPlotter and Setup errors into warnings, so that job's logs are searched forWARNING: shape plotting failed,Warning: no var_listandTraceback, and its datacards, limits and plots are checked to be present: on both backends (GitLab job 84465115 in https://gitlab.cern.ch/cms-flaf/flaf_integration/-/pipelines/16078964, GitHub Actions job 117581533118 in https://github.com/cms-flaf/FLAF/actions/runs/39089883382), the job ranResonantLimitsAndHistPlotTask --version CI --era Run3_2022 --test 1000, and the card built datacards for Run3_2022, Run3_2022EE, Run3_2023 and Run3_2023BPix.no shapes to plot for TwoStageDNN_M300_binary, 4 times), exactly as on main (GitHub Actions run 39033435835, before this change). That is pre-existing and not changed here.REVIEWER OK(flaf-reviewer, e1392d7).run_ci_test.shdoes not run StatInference; the integration pipelines above stand in for the tester verdict.