chore(logs): rename ingress-nginx GROK fields to OTel semantic conven…#1729
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR merges changes from an upstream logs-dev branch, bumping the Logs plugin/chart versions and updating the ingress-nginx GROK extraction in the containerd log pipeline to use OpenTelemetry (OTel) semantic attribute names.
Changes:
- Bump Logs PluginDefinition version to
0.13.9and chart reference to0.2.9. - Bump Helm chart version to
0.2.9. - Rename ingress-nginx GROK-extracted fields in the containerd pipeline to OTel semantic conventions (e.g.,
http.request.method,url.path,http.response.status_code,user_agent.original).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| logs/plugindefinition.yaml | Bumps plugin version and referenced chart version. |
| logs/charts/templates/_containerd-config.tpl | Renames ingress-nginx GROK output fields to OTel semantic keys (containerd pipeline). |
| logs/charts/Chart.yaml | Bumps Helm chart version to 0.2.9. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…tions Signed-off-by: I504010 <timo.johner@sap.com>
…tack pipeline Align all parsers in _openstack-config.tpl with OTel semantic conventions, consistent with the containerd pipeline changes: - request.method -> http.request.method - request.path -> url.path - response -> http.response.status_code - content_length -> http.response.body.size - user_agent -> user_agent.original - request.length -> http.request.body.size Affected transforms: ingress, neutron_agent, neutron_errors, openstack_api, non_openstack, elektra, keystone_api, swift_proxy Signed-off-by: I504010 <timo.johner@sap.com>
timojohlo
force-pushed
the
align-logs-dev
branch
from
bab6313 to
ef591e8
Compare
joluc
approved these changes
Jun 12, 2026
ztomaszewska
pushed a commit
that referenced
this pull request
Jun 16, 2026
#1729) * chore(logs): rename ingress-nginx GROK fields to OTel semantic conventions Signed-off-by: I504010 <timo.johner@sap.com> * chore(logs): rename GROK fields to OTel semantic conventions in openstack pipeline Align all parsers in _openstack-config.tpl with OTel semantic conventions, consistent with the containerd pipeline changes: - request.method -> http.request.method - request.path -> url.path - response -> http.response.status_code - content_length -> http.response.body.size - user_agent -> user_agent.original - request.length -> http.request.body.size Affected transforms: ingress, neutron_agent, neutron_errors, openstack_api, non_openstack, elektra, keystone_api, swift_proxy Signed-off-by: I504010 <timo.johner@sap.com> --------- Signed-off-by: I504010 <timo.johner@sap.com> Signed-off-by: Zuzanna Tomaszewska <zuzanna.tomaszewska@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merge changes from logs-dev