feat(logs): add standalone external collector for devices#1720
Open
timojohlo wants to merge 3 commits into
Open
feat(logs): add standalone external collector for devices#1720timojohlo wants to merge 3 commits into
timojohlo wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a standalone “external” OpenTelemetry Collector (StatefulSet) intended for ingesting device/external inputs (alertmanager webhooks, deployment TCP logs, syslog, and OTLP traces) separately from the existing node-level logs collector (DaemonSet).
Changes:
- Added a new
externalCollectorvalues block and anexternal-collector.yamltemplate to deploy a standalone OpenTelemetryCollector when any external ingestion feature is enabled. - Moved external-ingestion-related configuration (external events, syslog, syslog TLS cert, traces) off
logsCollectorand updated templates/docs accordingly. - Bumped plugin/chart versions and updated CI test values for the new configuration structure.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| logs/README.md | Documents new openTelemetry.externalCollector values and removes old logsCollector external-ingestion docs. |
| logs/plugindefinition.yaml | Bumps plugin/chart versions and exposes new feature flags for the standalone external collector. |
| logs/charts/Chart.yaml | Chart version bump to reflect the feature addition/breaking value reshaping. |
| logs/charts/values.yaml | Introduces openTelemetry.externalCollector configuration; removes logsCollector syslog/traces Kafka topics. |
| logs/charts/templates/logs-collector.yaml | Removes external-ingestion receivers/pipelines from the daemonset-based logs collector. |
| logs/charts/templates/external-collector.yaml | New OpenTelemetryCollector (StatefulSet) implementing external/syslog/traces ingestion and routing/exporting. |
| logs/charts/templates/external-service.yaml | Updates NodePort service to select the new external collector instance and new values paths. |
| logs/charts/templates/syslog-tls-certificate.yaml | Issues TLS cert based on externalCollector.syslogTLSConfig.enabled instead of logsCollector. |
| logs/charts/templates/_external-config.tpl | Repoints external receiver/exporter/pipeline helpers to externalCollector config. |
| logs/charts/templates/_traces-config.tpl | Repoints traces receiver/exporter/connectors to externalCollector config. |
| logs/charts/templates/_syslog-config.tpl | New syslog exporter/connectors/pipelines for the external collector. |
| logs/charts/ci/test-values.yaml | Updates CI values to use externalCollector.external_ip. |
| logs/charts/ci/test-values-all-features.yaml | Updates CI values for all external features under externalCollector. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
joluc
reviewed
Jun 15, 2026
joluc
reviewed
Jun 15, 2026
295fae4 to
d2698b5
Compare
Signed-off-by: I504010 <timo.johner@sap.com>
d2698b5 to
0d98d94
Compare
Signed-off-by: I504010 <timo.johner@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Introduces a standalone OpenTelemetry external collector (StatefulSet) that is independent from the existing logs DaemonSet collector. This new collector handles log ingestion from external devices — syslog (TCP/UDP/TLS) and traces (OTLP gRPC/HTTP) — and will later support routing to different kafka topics (audit, operational) based on defined attributes.