Skip to content

feat(logs): add standalone external collector for devices#1720

Open
timojohlo wants to merge 3 commits into
mainfrom
feat/external-collector
Open

feat(logs): add standalone external collector for devices#1720
timojohlo wants to merge 3 commits into
mainfrom
feat/external-collector

Conversation

@timojohlo

@timojohlo timojohlo commented Jun 10, 2026

Copy link
Copy Markdown
Member

Details

Introduces a standalone OpenTelemetry external collector (StatefulSet) that is independent from the existing logs DaemonSet collector. This new collector handles log ingestion from external devices — syslog (TCP/UDP/TLS) and traces (OTLP gRPC/HTTP) — and will later support routing to different kafka topics (audit, operational) based on defined attributes.

Copilot AI review requested due to automatic review settings June 10, 2026 14:07
@timojohlo timojohlo requested a review from a team as a code owner June 10, 2026 14:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a standalone “external” OpenTelemetry Collector (StatefulSet) intended for ingesting device/external inputs (alertmanager webhooks, deployment TCP logs, syslog, and OTLP traces) separately from the existing node-level logs collector (DaemonSet).

Changes:

  • Added a new externalCollector values block and an external-collector.yaml template to deploy a standalone OpenTelemetryCollector when any external ingestion feature is enabled.
  • Moved external-ingestion-related configuration (external events, syslog, syslog TLS cert, traces) off logsCollector and updated templates/docs accordingly.
  • Bumped plugin/chart versions and updated CI test values for the new configuration structure.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
logs/README.md Documents new openTelemetry.externalCollector values and removes old logsCollector external-ingestion docs.
logs/plugindefinition.yaml Bumps plugin/chart versions and exposes new feature flags for the standalone external collector.
logs/charts/Chart.yaml Chart version bump to reflect the feature addition/breaking value reshaping.
logs/charts/values.yaml Introduces openTelemetry.externalCollector configuration; removes logsCollector syslog/traces Kafka topics.
logs/charts/templates/logs-collector.yaml Removes external-ingestion receivers/pipelines from the daemonset-based logs collector.
logs/charts/templates/external-collector.yaml New OpenTelemetryCollector (StatefulSet) implementing external/syslog/traces ingestion and routing/exporting.
logs/charts/templates/external-service.yaml Updates NodePort service to select the new external collector instance and new values paths.
logs/charts/templates/syslog-tls-certificate.yaml Issues TLS cert based on externalCollector.syslogTLSConfig.enabled instead of logsCollector.
logs/charts/templates/_external-config.tpl Repoints external receiver/exporter/pipeline helpers to externalCollector config.
logs/charts/templates/_traces-config.tpl Repoints traces receiver/exporter/connectors to externalCollector config.
logs/charts/templates/_syslog-config.tpl New syslog exporter/connectors/pipelines for the external collector.
logs/charts/ci/test-values.yaml Updates CI values to use externalCollector.external_ip.
logs/charts/ci/test-values-all-features.yaml Updates CI values for all external features under externalCollector.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread logs/charts/templates/external-service.yaml Outdated
Comment thread logs/charts/templates/external-collector.yaml Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

Comment thread logs/charts/templates/external-collector.yaml Outdated
Comment thread logs/charts/templates/external-collector.yaml Outdated
Comment thread logs/charts/templates/external-collector.yaml
Comment thread logs/charts/templates/external-service.yaml Outdated
Comment thread logs/charts/ci/test-values-all-features.yaml Outdated
Comment thread logs/charts/values.yaml Outdated
@timojohlo timojohlo force-pushed the feat/external-collector branch 2 times, most recently from 295fae4 to d2698b5 Compare June 15, 2026 13:53
Signed-off-by: I504010 <timo.johner@sap.com>
@timojohlo timojohlo force-pushed the feat/external-collector branch from d2698b5 to 0d98d94 Compare June 15, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants