feat(alerts): extend alerting#1719
Merged
Merged
Conversation
Signed-off-by: trouaux <thomas.rouaux@sap.com>
trouaux
force-pushed
the
alertmanager-extend-alerting
branch
from
d0ad79a to
4f5018f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the alerts Helm chart by adding Alertmanager-related PrometheusRule resources imported from a legacy Alertmanager base, and bumps the plugin/chart versions accordingly.
Changes:
- Bump
alertsPluginDefinition version to9.0.1and chart version to8.0.1. - Add a new default-rules toggle (
k8sContainerMemoryWorkingSetBytes) to values. - Introduce an
AlertmanagerPrometheusRuletemplate with multiple alert rules.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
alerts/plugindefinition.yaml |
Version bump for the plugin and referenced chart. |
alerts/charts/Chart.yaml |
Chart version bump to align with the release. |
alerts/charts/values.yaml |
Adds a new default rule toggle for container memory working set bytes. |
alerts/charts/templates/prometheusRules.yaml |
Adds Alertmanager-focused PrometheusRule definitions (template currently has rendering/YAML issues noted in comments). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Can you address the copilot review please? |
Signed-off-by: trouaux <thomas.rouaux@sap.com>
trouaux
force-pushed
the
alertmanager-extend-alerting
branch
from
bea52b3 to
66ed989
Compare
ztomaszewska
pushed a commit
that referenced
this pull request
Jun 16, 2026
* extend alerting Signed-off-by: trouaux <thomas.rouaux@sap.com> * nit Signed-off-by: trouaux <thomas.rouaux@sap.com> * nits Signed-off-by: trouaux <thomas.rouaux@sap.com> * remove duplicate alert + rm playbook labels Signed-off-by: trouaux <thomas.rouaux@sap.com> --------- Signed-off-by: trouaux <thomas.rouaux@sap.com> Signed-off-by: Zuzanna Tomaszewska <zuzanna.tomaszewska@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import rules from legacy alertmanager base
https://github.com/sapcc/helm-charts/blob/master/common/prometheus-alertmanager-base/templates/alerts/_alertmanager.alerts.tpl