Skip to content

Support single-export config format in Vite plugin v2 - #15767

Merged
jamesopstad merged 25 commits into
vite-plugin-v2from
james/vite-plugin-v2-main-sync-2
Sep 22, 2026
Merged

jamesopstad merged 25 commits into
vite-plugin-v2from
james/vite-plugin-v2-main-sync-2

Conversation

@jamesopstad

Copy link
Copy Markdown
Contributor

Support single-export config format in Vite plugin v2


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: docs to follow

A picture of a cute animal (not mandatory, but encouraged)

ghostwriternr and others added 19 commits September 21, 2026 11:02
)

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wrangler automated PR updater <wrangler@cloudflare.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Chris Thorwarth <cthorwarth@cloudflare.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@changeset-bot

changeset-bot Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 19f30f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@15767

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@15767

@cloudflare/codemods

npm i https://pkg.pr.new/@cloudflare/codemods@15767

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@15767

@cloudflare/containers-shared

npm i https://pkg.pr.new/@cloudflare/containers-shared@15767

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@15767

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@15767

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@15767

miniflare

npm i https://pkg.pr.new/miniflare@15767

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@15767

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@15767

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@15767

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@15767

@cloudflare/vitest-plugin

npm i https://pkg.pr.new/@cloudflare/vitest-plugin@15767

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@15767

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@15767

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@15767

wrangler

npm i https://pkg.pr.new/wrangler@15767

commit: 19f30f5

ask-bonk[bot]

This comment was marked as resolved.

@ask-bonk

ask-bonk Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

I'm Bonk, and I've done a quick review of your PR.

Migrates Vite plugin v2 to the single-default-export config format.

  1. P1: Container references accepted as Worker bindings.
  2. P2: Generated types fail for conditional config unions.
  3. P2: Failed container directory validation leaves stale Docker images.
  4. P2: Windows path casing can cause recursive asset copying.

Posted 4 inline suggestion comments.

github run

@jamesopstad
jamesopstad force-pushed the james/vite-plugin-v2-main-sync-2 branch from dc4c701 to b1f0531 Compare September 22, 2026 10:17
@jamesopstad
jamesopstad force-pushed the james/vite-plugin-v2-main-sync-2 branch from b1f0531 to e4c92b3 Compare September 22, 2026 12:50
@jamesopstad
jamesopstad force-pushed the james/vite-plugin-v2-main-sync-2 branch from e4c92b3 to 19f30f5 Compare September 22, 2026 13:16
@jamesopstad
jamesopstad marked this pull request as ready for review September 22, 2026 13:27
@workers-devprod
workers-devprod requested review from a team and dario-piotrowicz and removed request for a team September 22, 2026 13:28
@workers-devprod

workers-devprod commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/cloudchamber
  • @cloudflare/d1
  • @cloudflare/workers-kv
  • @cloudflare/workflows
  • ✅ @cloudflare/wrangler
Show detailed file reviewers
  • packages/containers-shared/CHANGELOG.md: [@cloudflare/cloudchamber]
  • packages/containers-shared/README.md: [@cloudflare/cloudchamber]
  • packages/containers-shared/index.ts: [@cloudflare/cloudchamber]
  • packages/containers-shared/package.json: [@cloudflare/cloudchamber]
  • packages/containers-shared/src/build-output.ts: [@cloudflare/cloudchamber]
  • packages/containers-shared/src/client/models/CreateApplicationRolloutRequest.ts: [@cloudflare/cloudchamber]
  • packages/containers-shared/src/images.ts: [@cloudflare/cloudchamber]
  • packages/containers-shared/src/registry-images.ts: [@cloudflare/cloudchamber]
  • packages/containers-shared/src/ssh.ts: [@cloudflare/cloudchamber]
  • packages/containers-shared/src/utils.ts: [@cloudflare/cloudchamber]
  • packages/containers-shared/tests/build-output.test.ts: [@cloudflare/cloudchamber]
  • packages/containers-shared/tests/registry-images.test.ts: [@cloudflare/cloudchamber]
  • packages/containers-shared/tests/ssh.test.ts: [@cloudflare/cloudchamber]
  • packages/containers-shared/tests/utils.test.ts: [@cloudflare/cloudchamber]
  • packages/containers-shared/tsup.config.ts: [@cloudflare/cloudchamber]
  • packages/miniflare/test/plugins/kv/index.spec.ts: [@cloudflare/workers-kv]
  • packages/miniflare/test/plugins/kv/sites.spec.ts: [@cloudflare/workers-kv]
  • packages/workflows-shared/src/lib/delay.ts: [@cloudflare/workflows]
  • packages/wrangler/src/tests/containers/images.test.ts: [@cloudflare/cloudchamber]
  • packages/wrangler/src/cloudchamber/common.ts: [@cloudflare/cloudchamber]
  • packages/wrangler/src/cloudchamber/images/images.ts: [@cloudflare/cloudchamber]
  • packages/wrangler/src/containers/images.ts: [@cloudflare/cloudchamber]
  • packages/wrangler/src/containers/ssh.ts: [@cloudflare/cloudchamber]
  • packages/wrangler/src/d1/migrations/helpers.ts: [@cloudflare/d1]

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

Devin Review

Comment thread packages/vite-plugin-cloudflare/src/plugin-config.ts
Comment thread .changeset/warm-cats-preview.md
Comment thread packages/vite-plugin-cloudflare/src/__tests__/tunnel.spec.ts

@petebacondarwin petebacondarwin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners Bypass

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Sep 22, 2026
@jamesopstad
jamesopstad merged commit e84d5c7 into vite-plugin-v2 Sep 22, 2026
94 of 95 checks passed
@jamesopstad
jamesopstad deleted the james/vite-plugin-v2-main-sync-2 branch September 22, 2026 20:36
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.