fix: prepare local Container sidecars without configured images - #15765
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: c0620ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
cjol
and removed request for
a team
September 21, 2026 22:45
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
@cloudflare/containers-shared
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
Contributor
|
LGTM |
th0m
force-pushed
the
codex/cc-8733-egress-sidecar
branch
from
September 21, 2026 22:53
07b86e2 to
bc4488e
Compare
gabivlj
approved these changes
Sep 21, 2026
th0m
force-pushed
the
codex/cc-8733-egress-sidecar
branch
from
September 21, 2026 23:02
bc4488e to
45344ac
Compare
skepticfx
approved these changes
Sep 21, 2026
th0m
force-pushed
the
codex/cc-8733-egress-sidecar
branch
from
September 21, 2026 23:22
45344ac to
9493bba
Compare
th0m
force-pushed
the
codex/cc-8733-egress-sidecar
branch
from
September 21, 2026 23:36
9493bba to
4d97d97
Compare
cjol
approved these changes
Sep 22, 2026
cjol
left a comment
Member
There was a problem hiding this comment.
Devin's remaining comment seems legit,but not a blocker
workers-devprod
approved these changes
Sep 22, 2026
workers-devprod
left a comment
Contributor
There was a problem hiding this comment.
Codeowners reviews satisfied
th0m
force-pushed
the
codex/cc-8733-egress-sidecar
branch
from
September 22, 2026 16:12
4d97d97 to
8b60651
Compare
Contributor
Author
Thanks for the quick review @cjol I've reworked the clean up logic and looks like Devin is happy now. |
th0m
force-pushed
the
codex/cc-8733-egress-sidecar
branch
from
September 22, 2026 16:23
8b60651 to
c0620ff
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #CC-8733
Wrangler dev and Vite dev/preview skipped preparation when Containers had no configured application images. On a clean Docker cache, selecting an image through
start()failed because the required egress sidecar was missing.Prepare images whenever local Containers are enabled and configured, including when the application image list is empty. Preserve reload deduplication, retry behavior, per-worker registry authentication, and runtime image selection.
Validation:
A picture of a cute animal (not mandatory, but encouraged)
