Skip to content

fix: prepare local Container sidecars without configured images - #15765

Merged
th0m merged 1 commit into
mainfrom
codex/cc-8733-egress-sidecar
Sep 22, 2026
Merged

th0m merged 1 commit into
mainfrom
codex/cc-8733-egress-sidecar

Conversation

@th0m

@th0m th0m commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Fixes #CC-8733

Wrangler dev and Vite dev/preview skipped preparation when Containers had no configured application images. On a clean Docker cache, selecting an image through start() failed because the required egress sidecar was missing.

Prepare images whenever local Containers are enabled and configured, including when the application image list is empty. Preserve reload deduplication, retry behavior, per-worker registry authentication, and runtime image selection.

Validation:

  • 61 focused tests passed, including new sidecar-only preparation, disabled/absent Containers, reload/retry, and multiworker coverage.
  • Relevant builds, type checks, lint, and formatting passed locally.
  • Added Docker-backed CI tests for Wrangler dev and Vite dev/preview with the application image preloaded and the sidecar absent. Execution is pending CI.

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: local dev bug fix

A picture of a cute animal (not mandatory, but encouraged)
image


Devin Review

@changeset-bot

changeset-bot Bot commented Sep 21, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c0620ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Sep 21, 2026
@workers-devprod
workers-devprod requested review from a team and cjol and removed request for a team September 21, 2026 22:45
@workers-devprod

workers-devprod commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/cloudchamber
  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@pkg-pr-new

pkg-pr-new Bot commented Sep 21, 2026

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@15765

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@15765

@cloudflare/codemods

npm i https://pkg.pr.new/@cloudflare/codemods@15765

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@15765

@cloudflare/containers-shared

npm i https://pkg.pr.new/@cloudflare/containers-shared@15765

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@15765

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@15765

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@15765

miniflare

npm i https://pkg.pr.new/miniflare@15765

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@15765

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@15765

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@15765

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@15765

@cloudflare/vitest-plugin

npm i https://pkg.pr.new/@cloudflare/vitest-plugin@15765

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@15765

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@15765

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@15765

wrangler

npm i https://pkg.pr.new/wrangler@15765

commit: c0620ff

devin-ai-integration[bot]

This comment was marked as resolved.

@ask-bonk

ask-bonk Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

LGTM

github run

@th0m
th0m force-pushed the codex/cc-8733-egress-sidecar branch from 07b86e2 to bc4488e Compare September 21, 2026 22:53
devin-ai-integration[bot]

This comment was marked as resolved.

@th0m
th0m force-pushed the codex/cc-8733-egress-sidecar branch from bc4488e to 45344ac Compare September 21, 2026 23:02
@th0m
th0m force-pushed the codex/cc-8733-egress-sidecar branch from 45344ac to 9493bba Compare September 21, 2026 23:22
devin-ai-integration[bot]

This comment was marked as resolved.

@th0m
th0m force-pushed the codex/cc-8733-egress-sidecar branch from 9493bba to 4d97d97 Compare September 21, 2026 23:36
@th0m th0m added this to the Priority List milestone Sep 22, 2026

@cjol cjol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin's remaining comment seems legit,but not a blocker

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@th0m
th0m force-pushed the codex/cc-8733-egress-sidecar branch from 4d97d97 to 8b60651 Compare September 22, 2026 16:12
@th0m

th0m commented Sep 22, 2026

Copy link
Copy Markdown
Contributor Author

Devin's remaining comment seems legit,but not a blocker

Thanks for the quick review @cjol I've reworked the clean up logic and looks like Devin is happy now.

@th0m
th0m force-pushed the codex/cc-8733-egress-sidecar branch from 8b60651 to c0620ff Compare September 22, 2026 16:23
@th0m
th0m merged commit 1bdb96d into main Sep 22, 2026
55 checks passed
@th0m
th0m deleted the codex/cc-8733-egress-sidecar branch September 22, 2026 17:31
@github-project-automation github-project-automation Bot moved this from Untriaged to Done in workers-sdk Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants