[wrangler] Reject duplicate JSON config keys - #15764
Draft
yomna-shousha wants to merge 1 commit into
Draft
yomna-shousha wants to merge 1 commit into
yomna-shousha wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: b2dee07 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
LGTM |
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
@cloudflare/containers-shared
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
petebacondarwin
requested changes
Sep 22, 2026
petebacondarwin
left a comment
petebacondarwin
left a comment
Contributor
There was a problem hiding this comment.
LGTM - ideally we could try to upstream this check to the jsonc library itself!
| input: string, | ||
| file?: string, | ||
| options: jsoncParser.ParseOptions = { allowTrailingComma: true } | ||
| options: JSONCParseOptions = { allowTrailingComma: true } |
Contributor
There was a problem hiding this comment.
Let's tweak this so that you don't need to provide the allowTrailingComma if you are just trying to add the dedup check...
Suggested change
| options: JSONCParseOptions = { allowTrailingComma: true } | |
| options: JSONCParseOptions = { } |
and then further down:
options = { allowTrailingComma: true, ...options };
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Rejects duplicate object keys when reading Wrangler JSON/JSONC configuration files.
This makes malformed config like two top-level
previewsblocks fail with a direct parse error instead of silently keeping the last value or surfacing an unrelated preview onboarding error.Notes
I could not reproduce Scott's exact "missing previews block" error with two
previewskeys on Wrangler 4.136.1 locally. The duplicate-key config parsed as the last value andwrangler previewsucceeded, which suggests the failing Workers Builds run may have used a cached config withoutpreviews. This still tightens the confusing malformed-config case Patrick called out.Testing
pnpm --filter @cloudflare/workers-utils test run tests/parse.test.ts -t "duplicate object keys"pnpm --filter wrangler test run src/__tests__/preview.test.ts -t "rejects duplicate previews blocks"pnpm exec oxfmt --check packages/workers-utils/src/parse.ts packages/workers-utils/src/config/index.ts packages/workers-utils/tests/parse.test.ts packages/wrangler/src/__tests__/preview.test.ts