Conversation
The original upstream metadata suite supplies a mixed array of string and object Apple startup images. Vinext assumed every array entry had a url field, so string entries lost their href. Normalize each entry and emit Next.js's default Apple status-bar style when none is provided. Add Facebook app/admin and Pinterest rich-pin metadata rendering. Preserve multiple admins and scalar admin inputs, and serialize explicit false values instead of dropping them. Extend the public metadata types for these fields. Validation: - Original v16.2.6 metadata Apple/social cases: 2 passed, versus 2 failed in the unfiltered baseline. Other cases were not selected for this focused run and remaining metadata failures are tracked separately. - New mixed-image/social and false-value regressions fail before this fix. - Complete features and shims suites: 1660 passed. - Targeted vp check and vinext package build pass.
@vinext/cloudflare
create-vinext-app
@vinext/types
vinext
@cloudflare/workers-response-store
commit: |
Contributor
Performance benchmarksCompared 0 improved · 0 regressed · 6 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
Member
|
/bigbonk review for issues Time limit: 8 minutes. Complete the review and post all findings within that limit. |
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hrefbecause rendering assumes every entry is an object. Normalize each entry and emit the default Apple status-bar style when none is specified.falsePinterest values. Adds regressions based on the Next.js metadata suite.vite-plusdependency is not installed.