fix(constants): guard Node feature detection in browser imports - #3394
Merged
Merged
Conversation
Importing next/constants in a browser evaluated process?.features even when process was undeclared. Optional chaining does not protect an undeclared root identifier, so the generated client bundle threw before hydration and the upstream cache-components action form stayed at its initial value. Check typeof process before reading Node's optional TypeScript feature flag. Node keeps the existing CONFIG_FILES values; browsers and Edge runtimes without process safely retain the standard config extensions. Add a real browser-target constants bundle regression evaluated in a fresh VM without process. It fails with ReferenceError before the guard and passes now. Validation: - Original v16.2.6 cache-components.server-action suite: 3/3 passed, compared with 2/3 before this fix, without changing the upstream test or fixture. - Complete shims and browser-constants tests: 1315 passed. - Targeted vp check and vinext package build pass.
@vinext/cloudflare
create-vinext-app
@vinext/types
vinext
@cloudflare/workers-response-store
commit: |
Contributor
Performance benchmarksCompared 1 improved · 0 regressed · 5 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
Member
|
/bigbonk review for issues Time limit: 8 minutes. Complete the review and post all findings within that limit. |
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
next/constantsin a browser throws before hydration because optional chaining onprocess?.featuresstill requiresprocessto be declared. Guard the feature check withtypeof processso runtimes without that global retain the standard config extensions while Node preserves its existing behavior.process. The failure surfaced in the upstream cache-components server-action suite.