Conversation
The local port of Next.js app-rendering's ISR timestamp assertion was still skipped with an old claim that use(getData()) cached timestamps across requests. Running the unchanged assertion against the current development server shows that both page and layout timestamps change. No runtime fix or weakened assertion is needed. Enable the test and remove the stale diagnosis and proposed module-cache invalidation workaround. Keep the checks for timestamp presence as well as inequality so missing HTML cannot make the test pass. Update the tracking counts and explicitly limit this evidence to development rendering, which does not establish production ISR cache behavior. The mixed static/dynamic case remains skipped because upstream skips it. Validation: the targeted app-rendering, head, shim, and document run passed 1394 tests with one upstream skip. vp check passed for the changed test; formatting was applied to the tracking document. Original upstream E2E verification remains separate from this local coverage restoration. Upstream: https://github.com/vercel/next.js/blob/v16.2.6/test/e2e/app-dir/app-rendering/rendering.test.ts
@vinext/cloudflare
create-vinext-app
@vinext/types
vinext
@cloudflare/workers-response-store
commit: |
Contributor
Performance benchmarksCompared 0 improved · 0 regressed · 6 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
Member
|
/bigbonk review for issues Time limit: 8 minutes. Complete the review and post all findings within that limit. |
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
Contributor
|
Posted 2 actionable inline findings. |
Member
|
/bigbonk review for issues Time limit: 8 minutes. Complete the review and post all findings within that limit. |
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.