fix(cache): share query-independent response entries by james-elicx · Pull Request #3390 · cloudflare/vinext

james-elicx · 2026-09-22T16:17:42Z

Summary

Rebuild App Router query-string sharing around each adapter's admission boundary. Workers Response Store looks up a proven-eligible Server Page by pathname and representation, renders a miss with its original query, and stores only completed query-independent artifacts. Workers Cache canonicalizes the entrypoint URL and ctx.props only when explicit static/error route config or an exact-path/representation cacheability manifest supplies pre-lookup evidence. Otherwise the query stays in the key.
Static/error App Route Handlers also share by pathname; revalidate-only handlers remain query-keyed because eligibility alone does not prove independence. Explicit public dynamic responses remain full-query keyed. Client Pages without an explicit static contract conservatively bypass Response Store: prop serialization before client execution cannot prove an unused query.
Preserve Fetch Cache, use cache, Pages Router, rewrite destination, and representation boundaries. Add existing-demo-fixture regressions across KV, Workers Cache, Response Store service-binding and self-contained modes, including on-demand static exports, static handlers, HTML/RSC, client SSR, metadata, and explicit public policy.

Parity and safety

Next.js treats Page searchParams as a dynamic API (docs, test). A completed query-independent Server Page artifact is reusable by pathname; explicitly static routes provide build-time proof even for nonstandard default exports. A force-static Route Handler strips its request query (test). Explicit public policy may instead cache dynamic output separately by query (test).

A default Client Page currently cannot distinguish actual searchParams consumption from React's serialization of the client-reference prop. Workers Cache therefore keeps unproven Client Pages query-keyed; Response Store bypasses default Client Pages rather than admitting an empty-query false static artifact. This creates extra misses for Client Pages that ignore the prop, but prevents cross-query leakage. Workers Cache still buffers some cold misses before delivery, as before this PR; this change does not claim streaming-miss parity. Cache Components/PPR postponed-shell parity remains out of scope.

Verification

Focused local suites: ISR/App Page 130/130, Response Store data 18/18, and Response Store Miniflare 23/23 passed; changed-file checks passed.
Exact head 672c41614e7a6729feb36a26eb4b2d7645dc0038: CI passed (55 jobs). Deploy Examples passed on attempt 2. KV, Workers Cache, and Response Store deployed cache E2Es all passed on their first attempt; the unrelated preview smoke job passed on retry after a shell broken-pipe false negative (the same preview smoke script passed locally, 20/20).
Five independent reviews were clean at this head; timed Big Bonk returned LGTM.

Keep this PR draft for human review; do not merge or mark ready automatically.

pkg-pr-new · 2026-09-22T16:18:53Z

Open in StackBlitz

@vinext/cloudflare

npm i https://pkg.pr.new/@vinext/cloudflare@3390

create-vinext-app

npm i https://pkg.pr.new/create-vinext-app@3390

@vinext/types

npm i https://pkg.pr.new/@vinext/types@3390

vinext

npm i https://pkg.pr.new/vinext@3390

@cloudflare/workers-response-store

npm i https://pkg.pr.new/@cloudflare/workers-response-store@3390

commit: 7bd07d0

github-actions · 2026-09-22T16:22:04Z

Performance benchmarks

Compared 7bd07d0 against base 79a2d11 using alternating same-runner rounds. Next.js was unchanged and skipped.

0 improved · 0 regressed · 6 within ±1.5%

Scenario	Framework	Baseline	Current	Change
Client bundle size (gzip)	vinext	142.3 KB	143.9 KB	⚫ +1.1%
Client entry size (gzip)	vinext	129.7 KB	131.3 KB	⚫ +1.2%
Dev server cold start	vinext	3.23 s	3.22 s	⚫ -0.4%
Production build time	vinext	3.50 s	3.53 s	⚫ +0.9%
RSC entry closure size (gzip)	vinext	127.9 KB	129.7 KB	⚫ +1.5%
Server bundle size (gzip)	vinext	226.2 KB	228.9 KB	⚫ +1.2%

View detailed results and traces

_{🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head}

github-actions · 2026-09-22T16:22:11Z

Example	Preview	Production	Original
app-router-cloudflare	preview	production
pages-router-cloudflare	preview	production
app-router-playground	preview	production	original
realworld-api-rest	preview	production
nextra-docs-template	preview	production
benchmarks	preview	production
hackernews	preview	production	original
response-store-demo	preview	production
workers-cache	preview	production
kv	preview	production
static-export	preview	production
web	preview	production

james-elicx · 2026-09-22T16:59:02Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T17:05:05Z

LGTM!

github run

james-elicx · 2026-09-22T17:11:19Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T17:13:39Z

LGTM!

github run

james-elicx · 2026-09-22T17:17:54Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T17:20:35Z

LGTM!

github run

james-elicx · 2026-09-22T17:23:10Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T17:25:48Z

LGTM!

github run

james-elicx · 2026-09-22T17:35:01Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T17:38:53Z

LGTM!

github run

james-elicx · 2026-09-22T19:42:16Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T19:44:20Z

LGTM!

github run

james-elicx · 2026-09-23T01:56:45Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-23T02:00:13Z

LGTM!

github run

      // path, not runtime-attacker-controlled input — a false positive.
-      imports.push(`const ${varName} = () => import(${JSON.stringify(absPath)});`);
+      imports.push(
+        `const ${varName} = () => import(${JSON.stringify(absPath)})${clientConfig && Object.keys(clientConfig).length > 0 ? `.then((mod) => ({ ...mod, ...${JSON.stringify(clientConfig)} }))` : ""};`,


      // path, not runtime-attacker-controlled input — a false positive.
-      imports.push(`const ${varName} = () => import(${JSON.stringify(absPath)});`);
+      imports.push(
+        `const ${varName} = () => import(${JSON.stringify(absPath)})${clientConfig && Object.keys(clientConfig).length > 0 ? `.then((mod) => ({ ...mod, ...${JSON.stringify(clientConfig)} }))` : ""};`,


      // path, not runtime-attacker-controlled input — a false positive.
-      imports.push(`const ${varName} = () => import(${JSON.stringify(absPath)});`);
+      imports.push(
+        `const ${varName} = () => import(${JSON.stringify(absPath)})${clientConfig && Object.keys(clientConfig).length > 0 ? `.then((mod) => ({ ...mod, ...${JSON.stringify(clientConfig)} }))` : ""};`,


james-elicx · 2026-09-23T12:51:38Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-23T12:55:18Z

LGTM!

github run

…fication

james-elicx · 2026-09-23T23:39:05Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-23T23:41:42Z

LGTM!

github run

james-elicx marked this pull request as draft September 22, 2026 16:18

fix(cache): share completed App page entries across queries

5932366

james-elicx force-pushed the codex/query-independent-response-cache branch from 3d6dc29 to 5932366 Compare September 22, 2026 22:42

james-elicx added 12 commits September 22, 2026 23:45

test(cache): exercise public force-dynamic query variants

30883e6

fix(cache): keep Client Page queries isolated before proof

7791ae4

test(cache): distinguish Client Page serialization from usage

45e39ca

test(cache): cover Client Page isolation in inline response store

d94153d

fix(cache): warm explicit-public pages without static RSC capture

f3845ac

test(cache): verify deployed query parity across backends

c38ec18

fix(cache): prevent query leakage in shared App HTML

626f07b

fix(cache): sanitize direct ISR query bootstrap

e8ecf46

test(cache): require query sharing eligibility in adapter mocks

3492e6f

fix(cache): keep force-static hydration query-free

cf79636

test(cache): install Chromium for deployed hydration checks

a5eabad

fix(cache): certify force-static queries across response adapters

c98fff1

james-elicx added 2 commits September 23, 2026 11:49

fix(cache): retain safe Client Page ISR across query strings

d5b7aab

docs(cache): format query parity plan

b5c8606

github-advanced-security Bot found potential problems Sep 23, 2026

View reviewed changes

james-elicx added 13 commits September 23, 2026 12:00

fix(rsc): serialize Client Page query props as plain objects

478ce1e

fix(rsc): reuse Client Page query thenables across retries

044da4c

fix(cache): keep Client Page RSC query variants isolated

bade20d

fix(cache): certify force-static Client Page RSC separately

26f43c9

fix(cache): propagate Client Page proof to inner ISR routes

2cd46a7

test(cache): tolerate partial generated-route fixtures

8e7b3c4

fix(cache): guard slot-only Client Page RSC in inner ISR

39eef1e

fix(cache): reject escaped route config from static proof

26c9221

fix(cache): parse route config exports before static sharing

ebf0db9

fix(cache): preserve Client Page query fallback during ISR regeneration

5159038

test(cache): assert query isolation on every public RSC response

d797e5d

fix(cache): reject query-dependent ISR regeneration

99f83c9

test(cache): exclude both stale Client Page queries

0992299

james-elicx added 8 commits September 23, 2026 23:44

fix(cache): prove Client Page RSC sharing per adapter

293a4cf

fix(cache): observe late Client Page SSR query reads before RSC certi…

f29d4d8

…fication

docs(cache): describe paired RSC certification in deploy logs

f827661

fix(cache): require exact resolved path for paired RSC proof

900b31d

fix(cache): reject client query reads in static error mode

c88e157

test(cache): verify settled RSC sharing per adapter

0bf9c7e

fix(cache): keep unverified static-error Flight private

7b6b4e4

test(response-store): respect disabled edge purge in refresh check

7bd07d0

Conversation

james-elicx commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Parity and safety

Verification

Uh oh!

pkg-pr-new Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance benchmarks

Uh oh!

github-actions Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 23, 2026

Uh oh!

ask-bonk Bot commented Sep 23, 2026

Uh oh!

james-elicx commented Sep 23, 2026

Uh oh!

ask-bonk Bot commented Sep 23, 2026

Uh oh!

james-elicx commented Sep 23, 2026

Uh oh!

ask-bonk Bot commented Sep 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

james-elicx commented Sep 22, 2026 •

edited

Loading

pkg-pr-new Bot commented Sep 22, 2026 •

edited

Loading

github-actions Bot commented Sep 22, 2026 •

edited

Loading