refactor(cli): proxy dev and build to Vite by james-elicx · Pull Request #3380 · cloudflare/vinext

james-elicx · 2026-09-22T11:37:17Z

Summary

replace vinext dev and vinext build orchestration with in-process project-local Vite CLI delegation
retain only an actionable missing-config preflight, including option-aware positional roots
delete wrapper-owned lifecycle, logging, help, and obsolete build/dev argument parsing

Deliberate interface changes

Configless use now asks users to run vinext init. Vinext-only build flags move to vinext plugin configuration; shared Vite flags pass through unchanged.

Two pre-config wrapper behaviors cannot be preserved while these commands remain thin Vite proxies and direct Vite behaves identically:

Older configured CommonJS projects without an ESM package boundary need a one-time vinext init migration. The alias no longer edits package/config files before Vite loads them.
Static dependencies of a Vite config can no longer rely on the old wrapper loading .env before evaluation. Config-time values should be loaded explicitly with Vite loadEnv(mode, process.cwd(), ""); see the README for custom envDir guidance.

Both compatibility tradeoffs have open review threads for maintainer decision. They are not claimed as behavior-preserving.

Validation

packed proxy, signal, lock, and command contract tests
vp check
vp run vinext#build

PR 6 of 7.

pkg-pr-new · 2026-09-22T11:38:22Z

Open in StackBlitz

@vinext/cloudflare

npm i https://pkg.pr.new/@vinext/cloudflare@3380

create-vinext-app

npm i https://pkg.pr.new/create-vinext-app@3380

@vinext/types

npm i https://pkg.pr.new/@vinext/types@3380

vinext

npm i https://pkg.pr.new/vinext@3380

@cloudflare/workers-response-store

npm i https://pkg.pr.new/@cloudflare/workers-response-store@3380

commit: decd15e

james-elicx · 2026-09-22T11:38:36Z

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

github-actions · 2026-09-22T11:41:33Z

Example	Preview	Production	Original
app-router-cloudflare	preview	production
pages-router-cloudflare	preview	production
app-router-playground	preview	production	original
realworld-api-rest	preview	production
nextra-docs-template	preview	production
benchmarks	preview	production
hackernews	preview	production	original
response-store-demo	preview	production
workers-cache	preview	production
kv	preview	production
static-export	preview	production
web	preview	production

ask-bonk · 2026-09-22T11:41:48Z

Posted 1 actionable inline finding.

github run

james-elicx · 2026-09-22T11:51:41Z

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T11:58:33Z

Posted 2 actionable inline findings.

github run

james-elicx · 2026-09-22T12:17:49Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T12:21:45Z

Posted 1 actionable inline finding.

github run

james-elicx · 2026-09-22T12:39:52Z

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T12:43:42Z

Posted 1 actionable inline finding.

github run

james-elicx · 2026-09-22T12:46:16Z

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

james-elicx · 2026-09-22T12:49:12Z

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T12:50:38Z

Posted 1 actionable inline finding.

github run

james-elicx · 2026-09-22T23:57:41Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-23T00:04:52Z

+  const root = configPreflight(command);
+  const cliPath = resolveProjectViteCli(root);
+  process.argv = [process.execPath, cliPath, command, ...rawArgs];
+  await import(/* @vite-ignore */ pathToFileURL(cliPath).href);


[P2] Load dotenv before every config dependency evaluates

Delegating here means the replacement dotenv bootstrap in index.ts cannot run until the config imports vinext. ESM evaluates earlier static dependencies first, so a config such as import "./env-reader.mjs"; import vinext from "vinext" now lets env-reader.mjs observe .env values as missing (and can fail before vinext is imported). The previous CLI called loadDotenv() before loading Vite or any config module, and the new test only covers a config that imports vinext first. Please restore pre-config dotenv loading for the parsed root/mode, or cover static config dependencies with an equivalent bootstrap.

Confirmed: an ESM dependency of vite.config evaluates before the vinext plugin hook regardless of import order. Restoring wrapper-only pre-config dotenv would make vinext differ from direct vite, contrary to the required thin-proxy contract. The top adoption PR now explicitly documents the limitation and use of loadEnv in a config factory; I am leaving this thread unresolved as a deliberate compatibility decision for maintainer review.

ask-bonk · 2026-09-23T00:04:56Z

Posted 1 actionable inline finding.

github run

james-elicx added this pull request to stack #3382 September 22, 2026 11:37

james-elicx changed the title ~~codex/thin vinext proxies~~ refactor(cli): proxy dev and build to Vite Sep 22, 2026

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread packages/vinext/src/cli.ts Outdated

james-elicx force-pushed the codex/thin-vinext-proxies branch from 4597370 to dd4f40d Compare September 22, 2026 11:51

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread packages/vinext/src/cli.ts

Comment thread packages/vinext/src/cli.ts Outdated

james-elicx force-pushed the codex/thin-vinext-proxies branch from dd4f40d to b422b40 Compare September 22, 2026 12:16

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread packages/vinext/src/cli.ts Outdated

james-elicx force-pushed the codex/thin-vinext-proxies branch from b422b40 to 11dbc58 Compare September 22, 2026 12:39

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread packages/vinext/src/cli.ts Outdated

james-elicx force-pushed the codex/thin-vinext-proxies branch from e75c601 to 2b85ee3 Compare September 22, 2026 12:44

james-elicx force-pushed the codex/thin-vinext-proxies branch from 2b85ee3 to 4473a51 Compare September 22, 2026 12:48

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread packages/vinext/src/cli.ts Outdated

james-elicx added 25 commits September 23, 2026 00:51

refactor(dev): keep lock handle private

df74f01

fix(cli): detect configured roots after Vite options

97d80f0

fix(cli): resolve positional roots absolutely

1a4d8c1

fix(cli): resolve positional project Vite

aee05ee

fix(cli): preserve Vite flag parsing

783b8d5

fix(cli): recognize short inline config paths

f26e5d7

refactor(cli): remove legacy dev helper

d6294a1

fix(cli): match Vite optional flag parsing

a97e890

fix(cli): defer cross-command options to Vite

4904103

fix(cli): retain roots for delegated option errors

84c1b93

refactor(build): remove obsolete lifecycle runner

4b53509

fix(cli): defer missing option values to Vite

2b5c79b

fix(cli): preflight clustered Vite options

6f7100f

fix(cli): defer invalid short clusters to Vite

a395390

fix(cli): preserve delegated Vite argument behavior

54532be

test(cli): migrate multi-stage build harness

d316a44

fix(cli): preflight negated optional Vite flags

2d988f2

fix(cli): stop config preflight at option delimiter

d69871c

fix(cli): preserve Vite argument validation

9a4f16b

fix(cli): keep preflight and Vite resolution aligned

8d56457

fix(cli): avoid ambiguous project-local Vite selection

3d410b1

chore(cli): keep Vite option parser private

8dd9df9

refactor(build): remove obsolete hybrid session state

b7b287a

fix(cli): preflight bare negated Vite options

bfa87e2

fix(cli): defer malformed required negations to Vite

decd15e

james-elicx force-pushed the codex/thin-vinext-proxies branch from 3b63168 to decd15e Compare September 22, 2026 23:56

ask-bonk Bot reviewed Sep 23, 2026

View reviewed changes

james-elicx mentioned this pull request Sep 23, 2026

refactor(cli): adopt direct Vite commands #3381

Draft

Conversation

james-elicx commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Deliberate interface changes

Validation

Uh oh!

pkg-pr-new Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

github-actions Bot commented Sep 22, 2026

Uh oh!

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

Uh oh!

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

ask-bonk Bot Sep 23, 2026

Choose a reason for hiding this comment

Uh oh!

james-elicx Sep 23, 2026

Choose a reason for hiding this comment

Uh oh!

ask-bonk Bot commented Sep 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

james-elicx commented Sep 22, 2026 •

edited

Loading

pkg-pr-new Bot commented Sep 22, 2026 •

edited

Loading