Skip to content

feat(dev): run CLI lifecycle through Vite - #3379

Draft
james-elicx wants to merge 28 commits into
codex/cloudflare-build-lifecyclefrom
codex/vite-dev-lifecycle
Draft

feat(dev): run CLI lifecycle through Vite#3379
james-elicx wants to merge 28 commits into
codex/cloudflare-build-lifecyclefrom
codex/vite-dev-lifecycle

Conversation

@james-elicx

@james-elicx james-elicx commented Sep 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

  • move CLI dev defaults and lock handling behind the vinext Vite plugin
  • keep middleware-mode and ordinary programmatic servers lock-free
  • preserve one ownership-aware lock across Vite server restarts
  • keep resolved-port updates safe after close or ownership changes

Validation

  • Vite dev lifecycle and dev lock tests
  • vp check
  • vp run vinext#build

PR 5 of 7.

@james-elicx
james-elicx added this pull request to stack #3382 September 22, 2026 11:37
@pkg-pr-new

pkg-pr-new Bot commented Sep 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@vinext/cloudflare

npm i https://pkg.pr.new/@vinext/cloudflare@3379

create-vinext-app

npm i https://pkg.pr.new/create-vinext-app@3379

@vinext/types

npm i https://pkg.pr.new/@vinext/types@3379

vinext

npm i https://pkg.pr.new/vinext@3379

@cloudflare/workers-response-store

npm i https://pkg.pr.new/@cloudflare/workers-response-store@3379

commit: bdce520

@james-elicx

james-elicx commented Sep 22, 2026

Copy link
Copy Markdown
Member Author

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk[bot]
ask-bonk Bot reviewed Sep 22, 2026
View reviewed changes
Comment thread packages/vinext/src/index.ts Outdated
@ask-bonk

ask-bonk Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Posted 1 actionable inline finding. Targeted lifecycle and lockfile tests pass.

github run

@github-actions

github-actions Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor
Example Preview Production Original
app-router-cloudflare preview production
pages-router-cloudflare preview production
app-router-playground preview production original
realworld-api-rest preview production
nextra-docs-template preview production
benchmarks preview production
hackernews preview production original
response-store-demo preview production
workers-cache preview production
kv preview production
static-export preview production
web preview production

@james-elicx
james-elicx force-pushed the codex/vite-dev-lifecycle branch from 9cf531c to a07ebeb Compare September 22, 2026 11:51
@james-elicx

james-elicx commented Sep 22, 2026

Copy link
Copy Markdown
Member Author

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk[bot]
ask-bonk Bot reviewed Sep 22, 2026
View reviewed changes
Comment thread packages/vinext/src/index.ts Outdated
@ask-bonk

ask-bonk Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Posted 1 new actionable inline finding. Targeted lifecycle and lockfile tests pass.

github run

@james-elicx
james-elicx force-pushed the codex/vite-dev-lifecycle branch from a07ebeb to 5f0b14c Compare September 22, 2026 12:16
@james-elicx

james-elicx commented Sep 22, 2026

Copy link
Copy Markdown
Member Author

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk[bot]
ask-bonk Bot reviewed Sep 22, 2026
View reviewed changes
Comment thread packages/vinext/src/cli-dev-config.ts Outdated
@ask-bonk

ask-bonk Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Posted 1 new actionable inline finding. Targeted lifecycle and lockfile tests pass.

github run

@james-elicx
james-elicx force-pushed the codex/vite-dev-lifecycle branch from 5f0b14c to 23d95d2 Compare September 22, 2026 12:39
@james-elicx

james-elicx commented Sep 22, 2026

Copy link
Copy Markdown
Member Author

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

@james-elicx
james-elicx force-pushed the codex/vite-dev-lifecycle branch from 23d95d2 to 1586303 Compare September 22, 2026 12:44
@james-elicx

james-elicx commented Sep 22, 2026

Copy link
Copy Markdown
Member Author

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk[bot]
ask-bonk Bot reviewed Sep 22, 2026
View reviewed changes
Comment thread packages/vinext/src/index.ts Outdated
@ask-bonk

ask-bonk Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Posted 1 new actionable inline finding.

github run

@james-elicx

james-elicx commented Sep 22, 2026

Copy link
Copy Markdown
Member Author

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk[bot]
ask-bonk Bot reviewed Sep 22, 2026
View reviewed changes
Comment thread packages/vinext/src/index.ts Outdated
Comment thread packages/vinext/src/cli-dev-config.ts Outdated
@ask-bonk

ask-bonk Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Posted 2 new actionable inline findings. Targeted lifecycle and lockfile tests pass.

github run

@james-elicx
james-elicx force-pushed the codex/vite-dev-lifecycle branch from 21f3edf to 4b8f1ee Compare September 22, 2026 13:06
@james-elicx

james-elicx commented Sep 22, 2026

Copy link
Copy Markdown
Member Author

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

@james-elicx
james-elicx force-pushed the codex/vite-dev-lifecycle branch from 385d381 to 53dfadc Compare September 22, 2026 22:30
@james-elicx

james-elicx commented Sep 22, 2026

Copy link
Copy Markdown
Member Author

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

@ask-bonk

ask-bonk Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

No new findings. The three existing inline findings remain unresolved on the unchanged head.

github run

@james-elicx

james-elicx commented Sep 22, 2026

Copy link
Copy Markdown
Member Author

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

@ask-bonk

ask-bonk Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

LGTM!

github run

@james-elicx

james-elicx commented Sep 22, 2026

Copy link
Copy Markdown
Member Author

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk[bot]
ask-bonk Bot reviewed Sep 22, 2026
View reviewed changes
Comment thread packages/vinext/src/utils/vite-cli-invocation.ts
@ask-bonk

ask-bonk Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Posted 1 actionable inline finding. Current CI suite is green.

github run

@james-elicx

james-elicx commented Sep 22, 2026

Copy link
Copy Markdown
Member Author

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk[bot]
ask-bonk Bot reviewed Sep 22, 2026
View reviewed changes
Comment thread packages/vinext/src/cli-dev-config.ts Outdated
@ask-bonk

ask-bonk Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Posted 1 new actionable inline finding.

github run

@james-elicx

james-elicx commented Sep 22, 2026

Copy link
Copy Markdown
Member Author

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

@ask-bonk

ask-bonk Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

LGTM!

github run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ask-bonk ask-bonk[bot] ask-bonk[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@james-elicx