feat(build): run lifecycle through Vite by james-elicx · Pull Request #3377 · cloudflare/vinext

james-elicx · 2026-09-22T11:37:04Z

Summary

connect the shared lifecycle to full direct Vite CLI builds, including global options before the command
keep watch, targeted/SSR, ordinary programmatic, and nested Vite builds outside the top-level lifecycle
preserve configured prerender concurrency, resolved user plugins, custom output roots, and production semantics
isolate the auxiliary hybrid Pages bundle in its own named environment

Compatibility boundary

Vite evaluates config imports before plugin hooks. A config dependency that reads dotenv or NODE_ENV before the vinext import cannot be initialized by this plugin; move that read behind explicit Vite loadEnv in an early config dependency. The open review threads track this tradeoff of using direct Vite without wrapper-side initialization.

Validation

Vite command contract and invocation tests
prerender configuration tests
vp check
vp run vinext#build

PR 3 of 7.

pkg-pr-new · 2026-09-22T11:38:05Z

Open in StackBlitz

@vinext/cloudflare

npm i https://pkg.pr.new/@vinext/cloudflare@3377

create-vinext-app

npm i https://pkg.pr.new/create-vinext-app@3377

@vinext/types

npm i https://pkg.pr.new/@vinext/types@3377

vinext

npm i https://pkg.pr.new/vinext@3377

@cloudflare/workers-response-store

npm i https://pkg.pr.new/@cloudflare/workers-response-store@3377

commit: 023b79a

james-elicx · 2026-09-22T11:38:36Z

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

github-actions · 2026-09-22T11:41:31Z

Example	Preview	Production	Original
app-router-cloudflare	preview	production
pages-router-cloudflare	preview	production
app-router-playground	preview	production	original
realworld-api-rest	preview	production
nextra-docs-template	preview	production
benchmarks	preview	production
hackernews	preview	production	original
response-store-demo	preview	production
workers-cache	preview	production
kv	preview	production
static-export	preview	production
web	preview	production

github-actions · 2026-09-22T11:42:05Z

Performance benchmarks

Compared 023b79a against base 1f61de6 using alternating same-runner rounds. Next.js was unchanged and skipped.

1 improved · 0 regressed · 5 within ±1.5%

Scenario	Framework	Baseline	Current	Change
Client bundle size (gzip)	vinext	142.3 KB	142.3 KB	⚫ -0.0%
Client entry size (gzip)	vinext	129.7 KB	129.7 KB	⚫ -0.0%
Dev server cold start	vinext	3.29 s	3.23 s	🟢 -1.9%
Production build time	vinext	3.79 s	3.77 s	⚫ -0.7%
RSC entry closure size (gzip)	vinext	127.9 KB	127.8 KB	⚫ -0.1%
Server bundle size (gzip)	vinext	226.0 KB	225.9 KB	⚫ -0.0%

View detailed results and traces

_{🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head}

ask-bonk · 2026-09-22T11:46:06Z

Posted 3 actionable inline findings.

github run

james-elicx · 2026-09-22T11:51:41Z

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T12:01:56Z

Posted 3 actionable inline findings.

github run

james-elicx · 2026-09-22T12:17:45Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T12:22:23Z

Posted 1 actionable inline finding. Targeted tests pass after rebuilding vinext.

github run

james-elicx · 2026-09-22T12:39:52Z

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T12:43:16Z

Posted 1 actionable inline finding.

github run

james-elicx · 2026-09-22T12:46:16Z

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T12:48:35Z

Posted 1 actionable inline finding.

github run

james-elicx · 2026-09-22T13:07:48Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T13:11:24Z

Posted 2 actionable inline findings. Targeted unit tests pass.

github run

james-elicx · 2026-09-22T17:29:29Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T17:32:07Z

No new actionable findings beyond the existing inline review comments.

github run

james-elicx · 2026-09-22T19:51:50Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T19:55:00Z

No new actionable findings beyond the existing inline review comments.

github run

james-elicx · 2026-09-22T20:45:59Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T20:47:59Z

Posted 1 actionable inline finding. CI also reproduces the regression.

github run

james-elicx · 2026-09-22T20:58:13Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T21:04:08Z

Posted 1 actionable inline finding. Targeted CLI invocation tests pass.

github run

james-elicx · 2026-09-22T21:30:26Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T21:38:23Z

+  if (!viteCliBuildConfigNodeEnv) {
+    Reflect.set(process.env, "NODE_ENV", "production");
+  }
+  loadDotenv({ root: earlyViteCliInvocation.root, mode: earlyViteCliInvocation.mode });


P2: This eager load runs before Vite resolves envDir, so it loads the CLI root even when the project config sets envDir: false or points at a different directory. Since loadDotenv() never overwrites existing keys, the later config hook cannot correct values loaded from the wrong directory; a workspace .env.production can therefore override the app env, and envDir: false no longer disables vinext dotenv loading for direct CLI builds. Please defer mutation until the resolved env policy is known, or undo/reload the eager values once config resolves.

This is a deliberate pre-config compatibility boundary. Before this PR, vinext dev/build loaded root dotenv before evaluating vite.config, including when the eventual config set custom envDir or false; the migration contract explicitly preserves that behavior for both command spellings. Waiting for resolved envDir would break apps reading process.env while the config module is evaluated. The README now says custom envDir requires explicit Vite loadEnv to supply config-time values. I am leaving this thread visible for maintainer review of that tradeoff.

ask-bonk · 2026-09-22T21:38:27Z

Posted 2 actionable inline findings.

github run

james-elicx · 2026-09-22T21:47:46Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T21:50:52Z

Posted 1 actionable inline finding.

github run

james-elicx · 2026-09-22T22:14:28Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T22:20:04Z

+  if (!viteCliBuildConfigNodeEnv) {
+    Reflect.set(process.env, "NODE_ENV", "production");
+  }
+  loadDotenv({ root: earlyViteCliInvocation.root, mode: earlyViteCliInvocation.mode });


P2: This module side effect still runs too late for dependencies imported before vinext from the Vite config. With the supported --configLoader runner, a config such as import "./config-helper"; import vinext from "vinext" evaluates the helper first, so any module-scope read of process.env there sees neither .env.production nor the production NODE_ENV; only evaluating the later vinext import performs this load. The previous vinext build path initialized the environment before Vite loaded the config graph. Please move direct-CLI initialization ahead of config module evaluation (rather than relying on the position of the vinext import), or otherwise preserve dotenv/NODE_ENV for the whole config dependency graph.

ask-bonk · 2026-09-22T22:20:07Z

Posted 2 actionable inline findings. Targeted lifecycle and CLI tests pass.

github run

james-elicx · 2026-09-22T22:30:37Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T22:34:19Z

LGTM!

github run

james-elicx added this pull request to stack #3382 September 22, 2026 11:37

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread packages/vinext/src/utils/vite-cli-invocation.ts Outdated

Comment thread packages/vinext/src/index.ts Outdated

Comment thread packages/vinext/src/config/prerender.ts

james-elicx force-pushed the codex/vite-build-lifecycle branch from 078c7d0 to ab7311c Compare September 22, 2026 11:51

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread packages/vinext/src/build/lifecycle.ts Outdated

Comment thread packages/vinext/src/build/lifecycle.ts Outdated

Comment thread packages/vinext/src/build/lifecycle.ts Outdated

james-elicx force-pushed the codex/vite-build-lifecycle branch from ab7311c to 86e2104 Compare September 22, 2026 12:16

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread packages/vinext/src/utils/vite-cli-invocation.ts Outdated

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread packages/vinext/src/index.ts Outdated

james-elicx force-pushed the codex/vite-build-lifecycle branch from 7f41ce5 to 9341cf4 Compare September 22, 2026 12:44

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread packages/vinext/src/build/lifecycle.ts Outdated

james-elicx force-pushed the codex/vite-build-lifecycle branch from 9341cf4 to ae580bb Compare September 22, 2026 13:06

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread packages/vinext/src/index.ts Outdated

Comment thread packages/vinext/src/build/lifecycle.ts

feat(build): run lifecycle through Vite

9aac569

fix(build): clean hybrid session on failed environment build

bfd8164

james-elicx added 3 commits September 22, 2026 21:34

fix(build): honor resolved Vite build targets and plugins

9f9cec9

fix(build): preflight standalone before dependency changes

ce59c47

fix(build): use resolved cleanup policy for preparation

34a90bd

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread packages/vinext/src/index.ts

fix(dev): retain Pages environments during Vite serve

4b62179

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread packages/vinext/src/index.ts

fix(build): leave non-emitting Vite builds untouched

c3c34cc

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

fix(build): leave library mode outside app lifecycle

c1e9c72

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread packages/vinext/src/build/lifecycle.ts Outdated

fix(build): avoid persistent Vite lifecycle state

596dcab

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

fix(build): expose plain Pages environments to config hooks

023b79a

Conversation

james-elicx commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Compatibility boundary

Validation

Uh oh!

pkg-pr-new Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

github-actions Bot commented Sep 22, 2026

Uh oh!

github-actions Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance benchmarks

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

Uh oh!

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

ask-bonk Bot Sep 22, 2026

Choose a reason for hiding this comment

Uh oh!

james-elicx Sep 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026 •

edited

Loading

pkg-pr-new Bot commented Sep 22, 2026 •

edited

Loading

github-actions Bot commented Sep 22, 2026 •

edited

Loading