-
Notifications
You must be signed in to change notification settings - Fork 533
Rename the existing CloudflareContainerBackend to LegacyContainerBackend #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "@cloudflare/computer": major | ||
| "@cloudflare/dofs": minor | ||
| "@cloudflare/computer-rpc": minor | ||
| --- | ||
|
|
||
| Rename the platform-scheduled container backend to `LegacyContainerBackend`. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,6 @@ | |
| }, | ||
| "devDependencies": { | ||
| "typescript": "^6.0.3", | ||
| "wrangler": "^4.130.0" | ||
| "wrangler": "^4.137.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,6 @@ | |
| }, | ||
| "devDependencies": { | ||
| "typescript": "^6.0.3", | ||
| "wrangler": "^4.130.0" | ||
| "wrangler": "^4.137.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| node_modules/ | ||
| dist/ | ||
| .wrangler/ | ||
| .dev.vars* | ||
| !.dev.vars.example |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,6 +29,6 @@ | |
| }, | ||
| "devDependencies": { | ||
| "typescript": "^6.0.3", | ||
| "wrangler": "^4.130.0" | ||
| "wrangler": "^4.137.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| { | ||
| "name": "@example/computer-container", | ||
| "name": "@example/computer-container-legacy", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Renamed example breaks its CI job
Learn moreThe example was renamed both as a directory and as an npm workspace. The CI matrix still passes the old workspace name to Example: The Recommended fix: Update the container entry in the example matrix to use Was this helpful? React with 👍 or 👎 to provide feedback. |
||
| "version": "0.0.0", | ||
| "private": true, | ||
| "type": "module", | ||
|
|
@@ -17,6 +17,6 @@ | |
| }, | ||
| "devDependencies": { | ||
| "typescript": "^6.0.3", | ||
| "wrangler": "^4.130.0" | ||
| "wrangler": "^4.137.0" | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Example commands retain the old workspace name
The README and Wrangler comment still select
@example/computer-container. Contributors cannot run the renamed@example/computer-container-legacyworkspace with those commands.(Refers to this code)
Was this helpful? React with 👍 or 👎 to provide feedback.