Skip to content

Compare-and-update progress steps so a stale write cannot rewind the bar - #551

Open
fabi200123 wants to merge 2 commits into
cloudbase:mainfrom
fabi200123:compare-then-update-progress-bars
Open

fabi200123 wants to merge 2 commits into
cloudbase:mainfrom
fabi200123:compare-then-update-progress-bars

Conversation

@fabi200123

Copy link
Copy Markdown
Contributor

This PR adds the following:

  • updates the progress bar logic so the task and minion-pool progress updates now advance current_step only when the stored step is not already ahead, including a completed update that a late cast would otherwise overwrite
  • adds an integration test that checks the progress update logic

…bar.

Task and minion-pool progress updates now advance current_step only when the stored step is not already ahead, including a completed update that a late cast would otherwise overwrite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant