Repository navigation
Conversation
Fix an issue where the permission grant would fail when migrating hardened Windows Server images. The permission grant was initially added when using Nano Server as the minion image, which needed these extra permissions in order for DISM to write driver directories under `FileRepository`. This can fail either way if the migrated image is hardened, so best chance we have at success is to not fail on the `icacls` command and attempt installation anyway. NOTE: DISM only needs Modify permissions when installing drivers, while the permission grant command needs Full Control in order to change permissions, so there's a great chance that DISM installation would work anyway in a standard Server minion.
Dany9966
marked this pull request as draft
October 23, 2026 13:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an issue where the permission grant would fail when migrating hardened Windows Server images. The permission grant was initially added when using Nano Server as the minion image, which needed these extra permissions in order for DISM to write driver directories under
FileRepository. This can fail either way if the migrated image is hardened, so best chance we have at success is to not fail on theicaclscommand and attempt installation anyway.NOTE: DISM only needs Modify permissions when installing drivers, while the permission grant command needs Full Control in order to change permissions, so there's a great chance that DISM installation would work anyway in a standard Server minion.