Repository navigation
Add cloudbase init plugins common option - #549
Open
Cristi1324 wants to merge 2 commits into
Open
Cristi1324 wants to merge 2 commits into
Cristi1324 wants to merge 2 commits into
Conversation
Add data_transfer_mechanism, set_dhcp, and retain_user_credentials under common_target_options. The worker merges those rows onto each provider list, injects the fields into the destination schema, and removes core names before the provider call. A request that names only core options returns only those rows. OS morphing stores set_dhcp as nics_set_dhcp and stores retain_user_credentials on the morphing parameters.
Register cloudbase_init_plugins with the common destination options and the destination schema. OS morphing stores the list on the morphing parameters. Windows reads that list, then the provider argument, then coriolis.conf, then the default plugin list.
Cristi1324
changed the title
Cristi1324
marked this pull request as ready for review
October 22, 2026 12:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the Cloudbase-Init plugin list as a common destination option.
Register cloudbase_init_plugins with the common destination options and
the destination schema. OS morphing stores the list on the morphing
parameters. Windows reads that list, then the provider argument, then
coriolis.conf, then the default plugin list.
Summary
cloudbase_init_pluginsis a common destination option.[common_target_options]is used when the destination environment omits the list.coriolis.confomit the list.coriolis.conf, and the provider omit the list.Test plan
data_transfer_mechanism,set_dhcp, andretain_user_credentials.set_dhcp. Confirm the response contains only that row.set_dhcpset to false. Confirm the guest keeps its static addresses.retain_user_credentialsset to true. Confirm the destination platform keeps the existing guest credentials.set_dhcpomitted. Confirm OS morphing uses the[common_target_options]value fornics_set_dhcp.cloudbase_init_pluginsset to one plugin. Confirm Windows OS morphing enables that plugin.cloudbase_init_pluginsset to an empty list. Confirm Windows OS morphing enables no plugins from that list.cloudbase_init_pluginsset in[common_target_options]and omitted from the destination environment. Confirm Windows OS morphing uses that list.cloudbase_init_pluginsomitted from the destination environment and fromcoriolis.conf. Confirm Windows OS morphing uses the default plugin list.data_transfer_mechanism=SSHin[cloudstack_migration_provider]. Confirm the replica does not set up the HTTPS backup writer.Depends on/Includes: #503