Repository navigation
integration: Adds test for disk snapshot revert on failed deployment - #546
Open
claudiubelu wants to merge 1 commit into
Open
claudiubelu wants to merge 1 commit into
claudiubelu wants to merge 1 commit into
Conversation
With clone_disks=False, the deployment modifies the replica's own disks in place, so a snapshot of them is taken beforehand. If the deployment fails: - the snapshot is kept (its deletion task does not run on error); - CLEANUP_FAILED_INSTANCE_DEPLOYMENT runs; - RESTORE_TRANSFER_DISK_SNAPSHOTS then reverts the disks to the snapshot, so the replica is left in its pre-deployment state. This test checks that the last two tasks run to completion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
clone_disks=False, the deployment modifies the replica's own disks in place, so a snapshot of them is taken beforehand. If the deployment fails:CLEANUP_FAILED_INSTANCE_DEPLOYMENTruns;RESTORE_TRANSFER_DISK_SNAPSHOTSthen reverts the disks to the snapshot, so the replica is left in its pre-deployment state.This test checks that the last two tasks run to completion.