Repository navigation
Show disk name and size in storage mapping - #958
Open
mihaelabalutoiu wants to merge 1 commit into
Open
mihaelabalutoiu wants to merge 1 commit into
mihaelabalutoiu wants to merge 1 commit into
Conversation
Add the `name` and `size` under the ID of the disk, so the disks of a VM can be told apart. Providers which don't export a `name` fall back to the `path` identifying the disk. Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, a disk in
storage mappingwas identified by its ID alone. Disk IDs aren't shown anywhere in the source platform's own UI, so when a VM had more than one disk there was no reliable way to know which one a row was mapping.We've added the disk's
nameandsizeunder the ID for each row in theDisk Mappingsection, both in the wizard and when editing an existing transfer. The ID stays first because the mapping is keyed on it.