Skip to content

Keep initial Draft time out of Objective clocks - #651

Merged
kirkmarple-clockgrove merged 2 commits into
mainfrom
fix/649-filing-clock
Nov 19, 2026
Merged

kirkmarple-clockgrove merged 2 commits into
mainfrom
fix/649-filing-clock

Conversation

@kirkmarple-clockgrove

Copy link
Copy Markdown
Contributor

Refs #649.

The public release check opened scratch #55 with Objective and Draft in one GitHub request. GitHub recorded Objective at issue creation and Draft one second later. The candidate treated the first event as activation and would have included draft preparation in the run clock and walk-away inputs. The scratch issue was closed before Draft removal or provider work.

Pass the original issue record into the shared activation reader. It recognizes the adjacent-second filing pair when both labels match the issue author and no intervening work is recorded. Legacy direct starts and later Draft holds retain their original timing.

The exact captured issue and timeline replay correctly as held before release. Adding synthetic release and merge records starts both clocks at Draft removal and counts zero human actions. The finish-card and scorecard regression tests exercise the adjacent-second filing alongside legacy and intervening-work cases. The shipped skills already specify Draft removal as the start and their manifest is unchanged.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T08:37:12.372162Z e160ed9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kirkmarple-clockgrove
kirkmarple-clockgrove added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit 9965255 Nov 19, 2026
10 checks passed
@kirkmarple-clockgrove
kirkmarple-clockgrove deleted the fix/649-filing-clock branch November 19, 2026 08:36

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e160ed98bb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread bench/test/score.test.mjs
const [filed, ...working] = c.issueTimeline;
const draft = { ...filed, label: { name: "pendulum:draft" } };
c.issue = { ...c.issue, created_at: filed.created_at, user: filed.actor };
const draft = { ...filed, label: { name: "pendulum:draft" }, created_at: "2031-03-02T01:00:01Z" };

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the held fixture to match the new label timestamps

Moving Draft one second after Objective makes the existing held fixture (issueTimeline: [draft, filed] at line 61) inconsistent with chronological timeline order. draftFiledTogether() requires Objective to precede Draft in the supplied array, so this fixture retains the Objective activation and the assertion at line 63 fails with ['2031-03-02T01:00:00Z', null, true] instead of [null, null, false]. This reproduces with node --test --test-name-pattern='Draft removal starts the walk-away' bench/test/score.test.mjs and breaks the Bench tests step in .github/workflows/quality.yml. Use [filed, draft] for the adjacent-second case, or give the reverse-order fixture timestamps consistent with Draft being applied first.

AGENTS.md reference: AGENTS.md:L7-L7

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant