Repository navigation
Keep initial Draft time out of Objective clocks - #651
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e160ed98bb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const [filed, ...working] = c.issueTimeline; | ||
| const draft = { ...filed, label: { name: "pendulum:draft" } }; | ||
| c.issue = { ...c.issue, created_at: filed.created_at, user: filed.actor }; | ||
| const draft = { ...filed, label: { name: "pendulum:draft" }, created_at: "2031-03-02T01:00:01Z" }; |
There was a problem hiding this comment.
Update the held fixture to match the new label timestamps
Moving Draft one second after Objective makes the existing held fixture (issueTimeline: [draft, filed] at line 61) inconsistent with chronological timeline order. draftFiledTogether() requires Objective to precede Draft in the supplied array, so this fixture retains the Objective activation and the assertion at line 63 fails with ['2031-03-02T01:00:00Z', null, true] instead of [null, null, false]. This reproduces with node --test --test-name-pattern='Draft removal starts the walk-away' bench/test/score.test.mjs and breaks the Bench tests step in .github/workflows/quality.yml. Use [filed, draft] for the adjacent-second case, or give the reverse-order fixture timestamps consistent with Draft being applied first.
AGENTS.md reference: AGENTS.md:L7-L7
Useful? React with 👍 / 👎.
Refs #649.
The public release check opened scratch #55 with Objective and Draft in one GitHub request. GitHub recorded Objective at issue creation and Draft one second later. The candidate treated the first event as activation and would have included draft preparation in the run clock and walk-away inputs. The scratch issue was closed before Draft removal or provider work.
Pass the original issue record into the shared activation reader. It recognizes the adjacent-second filing pair when both labels match the issue author and no intervening work is recorded. Legacy direct starts and later Draft holds retain their original timing.
The exact captured issue and timeline replay correctly as held before release. Adding synthetic release and merge records starts both clocks at Draft removal and counts zero human actions. The finish-card and scorecard regression tests exercise the adjacent-second filing alongside legacy and intervening-work cases. The shipped skills already specify Draft removal as the start and their manifest is unchanged.