[MartinKanera]

Summary

mvc.$(window) has returned an empty collection since 4.0.0. A window has no nodeType, so the Dom constructor treats it as an array-like and copies window.length items, which are the page's frames. Events bound through it go nowhere, and the el === window branches of width()/height() are unreachable through $(window). With this change, $(window) holds the window, so the event methods and width()/height() work on it.

Changes

• Dom constructor: holds any window, an iframe's contentWindow included, as a one-item collection. The check uses jQuery's window test (obj != null && obj === obj.window) right after the DOM-element branch, so on a page with iframes $(window) holds the window instead of its frames.
• width() and height(): test for any window instead of el === window, so an iframe's window measures its own document.
• Only on(), one(), off(), width() and height() support a window, and a comment on the constructor branch says so. The prop() aliases (innerWidth(), outerWidth(), scrollTop(), ...) read undefined and their setters write a plain property onto the window. Most other element methods throw a TypeError.
• Methods that pass a window on to $(): $(el).add(window) adds the window. closest(window), appendTo(window), prependTo(window) and a view with el: window throw a TypeError, as they already did on a page with an iframe.
• Other calls that change: inside an iframe, $(window.parent) holds the parent window instead of the parent's frames, and a one() handler bound through $([window]) now removes itself after it runs.
• Tests: a $(window) module that pins the constructor (alone, on a page with an iframe, and an iframe's window), width()/height() on the window and on an iframe's window, and on(), one() and off().
• A patch changeset for @joint/core.

Verification

• yarn workspace @joint/core lint: pass
• yarn workspace @joint/core test: pass (Karma 2146/2146, geometry 350/350, vectorizer 453/453, mocha, qunit, TypeScript; coverage thresholds included)
• Test first: the 8 new tests failed before the fix. With only the constructor branch, the iframe width()/height() test still failed with a TypeError. A width() that returns window.innerWidth fails the scrollbar test, and so does a height() that returns window.innerHeight.
• yarn changeset status --since=upstream/master: @joint/core patch
• Browser: no separate check, since nothing in core calls $(window)

[Copilot]

🟡 Changes recommended

Unguarded collection-building APIs can still contain windows, causing regressions in width() and height().

1 open finding

• Preserve window handling for pushStack and $.merge collections · New

What changed in this PR

This PR makes mvc.$ reject window objects instead of silently wrapping them.

Changes:

• Detect windows in direct and array-like inputs.
• Remove window-specific measurement handling.
• Add QUnit coverage and a patch changeset.

File	Description
Dom.mjs	Rejects window-containing inputs.
methods.mjs	Removes viewport measurement branches.
mvc.Dom.js	Tests direct, iframe, and array-contained windows.
Changeset	Documents the behavioral change.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.